971745 - java.lang.IndexOutOfBoundsException: at java.util.LinkedList.get(LinkedList.java) in moveToParentFolder()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

bp-d921420f-ec6a-47ab-b2c9-f46172140211

java.lang.IndexOutOfBoundsException
	at java.util.LinkedList.get(LinkedList.java:519)
	at org.mozilla.gecko.home.BookmarksListAdapter.moveToParentFolder(BookmarksListAdapter.java:141)
	at org.mozilla.gecko.home.BookmarksListView$1.onKey(BookmarksListView.java:58)
	at android.view.View.dispatchKeyEvent(View.java:7660)
	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1403)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Ignore Back presses while initial bookmark list is loading (r=mfinkle)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8374861 [details] [diff] [review]
Ignore Back presses while initial bookmark list is loading (r=mfinkle)

There's a very short window of time where parent stack doesn't contain the root FolderInfo yet. This means we'll crash if the user presses the Back button before the initial list of bookmarks is loaded.

Comment 3

[Lucas Rocha (:lucasr)]

Added a shorter version of the comment above to the code btw.

Comment 4

[Lucas Rocha (:lucasr)]

This is a top crasher in Fx30 btw.

Comment 5

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/adaff41aff37

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 8374861 [details] [diff] [review]
Ignore Back presses while initial bookmark list is loading (r=mfinkle)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new about:home stuff in Fx26
User impact if declined: top crasher in Fx30 and likely frequent in Aurora and Beta
Testing completed (on m-c, etc.): Let's land this in nightly and gradually uplift to Aurora then Beta, keeping an eye on crash stats.
Risk to taking this patch (and alternatives if risky): Very low, one-line patch.
String or IDL/UUID changes made by this patch: n/a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/adaff41aff37

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8374861 [details] [diff] [review]
Ignore Back presses while initial bookmark list is loading (r=mfinkle)

If we want to get stats, let's land this to branches so it's in the next mobile beta (on Monday) and gets to more users for better feedback.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1dded3ff0ca3
https://hg.mozilla.org/releases/mozilla-beta/rev/c1f340448e72

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/c1f340448e72