Closed
Bug 971830
Opened 10 years ago
Closed 10 years ago
Utilize get(Audio|Video)Tracks() from 834835 in mochitest
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: drno, Assigned: drno)
Details
Attachments
(1 file, 1 obsolete file)
1.37 KB,
patch
|
drno
:
review+
|
Details | Diff | Splinter Review |
Utilize getAudioTracks() and getVideoTracks() from bug 834835 in mochitest to replace the hardwired values in pc.js.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → drno
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8374974 -
Flags: review?(hskupin)
Comment 2•10 years ago
|
||
Comment on attachment 8374974 [details] [diff] [review] properly_name_remote_audio_video_streams.patch Review of attachment 8374974 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me. Please fix the nits and you have me r+. Did you send it already to try? I wonder if we need other fixes for checks regarding the new 'audio' part in the type string. In the future you might want to add the try build request as comment to the bug. ::: dom/media/tests/mochitest/pc.js @@ +1105,4 @@ > > + var type = ''; > + if (event.stream.getAudioTracks().length > 0) { > + type = 'audio'; nit: 2 blanks instead of 4 please.
Attachment #8374974 -
Flags: review?(hskupin) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8374974 -
Attachment is obsolete: true
Assignee | ||
Comment 3•10 years ago
|
||
Addressed the nits. Carrying forward r+=hskupin
Attachment #8376418 -
Flags: review+
Assignee | ||
Comment 4•10 years ago
|
||
Try server run: https://tbpl.mozilla.org/?tree=Try&rev=2249d7b6dda3
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
(In reply to Nils Ohlmeier [:drno] from comment #4) > Try server run: https://tbpl.mozilla.org/?tree=Try&rev=2249d7b6dda3 This build caused a failure on Windows 8 debug in the basic Audio/Video peerconnection test. Can we be sure it is not a problem by this patch? https://tbpl.mozilla.org/php/getParsedLog.php?id=34716571&tree=Try
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7173c66302c3
Flags: in-testsuite+
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7173c66302c3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•