Closed Bug 971830 Opened 6 years ago Closed 6 years ago

Utilize get(Audio|Video)Tracks() from 834835 in mochitest

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file, 1 obsolete file)

Utilize getAudioTracks() and getVideoTracks() from bug 834835 in mochitest to replace the hardwired values in pc.js.
Assignee: nobody → drno
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Attachment #8374974 - Flags: review?(hskupin)
Comment on attachment 8374974 [details] [diff] [review]
properly_name_remote_audio_video_streams.patch

Review of attachment 8374974 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Please fix the nits and you have me r+. Did you send it already to try? I wonder if we need other fixes for checks regarding the new 'audio' part in the type string. In the future you might want to add the try build request as comment to the bug.

::: dom/media/tests/mochitest/pc.js
@@ +1105,4 @@
>  
> +    var type = '';
> +    if (event.stream.getAudioTracks().length > 0) {
> +        type = 'audio';

nit: 2 blanks instead of 4 please.
Attachment #8374974 - Flags: review?(hskupin) → review+
Attachment #8374974 - Attachment is obsolete: true
Addressed the nits. Carrying forward r+=hskupin
Attachment #8376418 - Flags: review+
Keywords: checkin-needed
(In reply to Nils Ohlmeier [:drno] from comment #4)
> Try server run: https://tbpl.mozilla.org/?tree=Try&rev=2249d7b6dda3

This build caused a failure on Windows 8 debug in the basic Audio/Video peerconnection test. Can we be sure it is not a problem by this patch?

https://tbpl.mozilla.org/php/getParsedLog.php?id=34716571&tree=Try
https://hg.mozilla.org/mozilla-central/rev/7173c66302c3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.