971832 - Create frontend JS module to provide auth for Webmaker

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Jon Buckley [:jbuck]]

We'll need a frontend JS module to provide auth for Webmaker. It should:

1) Use navigator.id.get() to avoid Persona's state management
2) Doesn't log in on every page load
3) Has working SSO for webmaker.org
4) A better user creation experience

Comment 1

[Chris DeCairos (:cade)]

In testing, I noticed that webmaker-auth-client isn't emitting the user object to it's event listener callbacks for the login event.

for example: https://github.com/cadecairos/webmaker.org/compare/new-login#diff-08f8485df196e866f46aa7f87a4c4b62R27 - in this callback, user is undefined.

Comment 2

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker-auth-client

Comment 3

[inactivate account for kate]

Comment on attachment 8375937 [details]
https://github.com/mozilla/webmaker-auth-client

https://github.com/mozilla/webmaker-auth-client

Comment 4

[Chris DeCairos (:cade)]

Comment on attachment 8375937 [details]
https://github.com/mozilla/webmaker-auth-client

There's some issues when you run `grunt validate` and `grunt jshint:all`

Comment 5

[Chris DeCairos (:cade)]

Comment on attachment 8375937 [details]
https://github.com/mozilla/webmaker-auth-client

Needs some lint fixes, also jsbeautifier says it needs to be run. Otherwise this looks great.

Comment 6

[inactivate account for kate]

Comment on attachment 8375937 [details]
https://github.com/mozilla/webmaker-auth-client

https://github.com/mozilla/webmaker-auth-client

Comment 7

[inactivate account for kate]

Comment on attachment 8375937 [details]
https://github.com/mozilla/webmaker-auth-client

Ok it's all beautified

Comment 8

[Chris DeCairos (:cade)]

Comment on attachment 8375937 [details]
https://github.com/mozilla/webmaker-auth-client

r+