971839 - Implement new Webmaker auth for webmaker.org

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Jon Buckley [:jbuck]]

Once all the new Webmaker auth components are ready, we'll need to implement them in webmaker.org.

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/602

This is a Work in Progress, but it's coming together!

Comment 2

[Chris DeCairos (:cade)]

Comment on attachment 8375615 [details] [review]
https://github.com/mozilla/webmaker.org/pull/602

almost there!

Comment 6

[Jon Buckley [:jbuck]]

Comment on attachment 8375615 [details] [review]
https://github.com/mozilla/webmaker.org/pull/602

I added some comments to the PR. Nothing big though!

Comment 7

[Chris DeCairos (:cade)]

Comment on attachment 8375615 [details] [review]
https://github.com/mozilla/webmaker.org/pull/602

Fixed up the issues. There's one still left - `grunt recess:dist` fails to compile our less file due to an import we added fr the create users css

Comment 8

[inactivate account for kate]

The grunt error should be resolved now with https://bugzilla.mozilla.org/show_bug.cgi?id=973964 being on master

Comment 9

[Jon Buckley [:jbuck]]

Comment on attachment 8375615 [details] [review]
https://github.com/mozilla/webmaker.org/pull/602

This looks pretty good with some nits in the PR and why is public/img/browser-off.png being modified in this patch?

Comment 10

[Jon Buckley [:jbuck]]

Also, seeing if we can fix the CSS for the events page

Comment 11

[inactivate account for kate]

Comment on attachment 8375615 [details] [review]
https://github.com/mozilla/webmaker.org/pull/602

Please add the #webmaker-logout back to include.less for legacy login apps

After that R+

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/26d512559cb4137e5dae47afb824d51c368953fd
Bug 971839 - Implement new log-in system on webmaker.org