Closed Bug 971842 Opened 12 years ago Closed 12 years ago

Implement new Webmaker auth for goggles.webmaker.org

Categories

(Webmaker Graveyard :: X-Ray Goggles, defect)

Product:
Webmaker Graveyard
Component:
X-Ray Goggles
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jon, Assigned: cade)

References

Details

(Whiteboard: login2-phase3)

Attachments

(2 files)

https://github.com/mozilla/goggles.webmaker.org/pull/103
56 bytes, text/x-github-pull-request
cade
: review+
Details | Review
https://github.com/mozilla/goggles.webmaker.org/pull/105
56 bytes, text/x-github-pull-request
jon
: review+
Details | Review
Once all the new Webmaker auth components are ready, we'll need to implement them in goggles.webmaker.org.
Whiteboard: login2
Whiteboard: login2 → login2-followup
Assignee: nobody → pomax
Whiteboard: login2-followup → login2-followup2
Whiteboard: login2-followup2 → login2-phase3
Clicking the login button doesn't seem to be working.
Comment on attachment 8382614 [details] [review] https://github.com/mozilla/goggles.webmaker.org/pull/103 Some comments in the pr. Also, everything seems to work fine cept clicking on the login button itself. If I am already logged in, it's a ok so far.
Attachment #8382614 - Flags: review?(scott) → review-
Also not sure if it is related, but attempting to publish a goggles make I get "Sorry, an error occurred. Please try again later."
hm, publishing worked on my end, did you copy the env.dist to ensure the right vars?
Flags: needinfo?(scott)
Status: NEW → ASSIGNED
Comment on attachment 8382614 [details] [review] https://github.com/mozilla/goggles.webmaker.org/pull/103 PR comments addressed and env.dist updated to actually have the persona login server URL
Attachment #8382614 - Flags: review- → review?(scott)
Comment on attachment 8382614 [details] [review] https://github.com/mozilla/goggles.webmaker.org/pull/103 Main login button working now. Also publishing doesn't error at the same spot. Seems now though that the publish dialog has a login button too, and that one doesn't seem to be working.
Attachment #8382614 - Flags: review?(scott) → review-
Flags: needinfo?(scott)
Comment on attachment 8382614 [details] [review] https://github.com/mozilla/goggles.webmaker.org/pull/103 Stealing this review
Attachment #8382614 - Flags: review- → review?(cade)
Comment on attachment 8382614 [details] [review] https://github.com/mozilla/goggles.webmaker.org/pull/103 left a few comments in the PR
Attachment #8382614 - Flags: review?(cade) → review-
Comment on attachment 8382614 [details] [review] https://github.com/mozilla/goggles.webmaker.org/pull/103 After I sign in, the log in button doesn't hide. Seeing this JS error in the console: ReferenceError: loginButtonSpan is not defined
Attachment #8382614 - Flags: review?(cade) → review-
Comment on attachment 8382614 [details] [review] https://github.com/mozilla/goggles.webmaker.org/pull/103 I don't know how, but some code that should have been on github, wasn't on github. Respun, this should work.
Attachment #8382614 - Flags: review- → review?(cade)
landed.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
We're missing a domain pref for webmaker-auth
Assignee: pomax → cade
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: