971848 - Implement new Webmaker auth for makeapi.webmaker.org

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Jon Buckley [:jbuck]]

Once all the new Webmaker auth components are ready, we'll need to implement them in makeapi.webmaker.org.

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/198

This is a fairly large patch - though more deletions than additions.

In order to get the new auth routes working, I had to remove the old login-api, which caused a lot of cascading changes to how we handle loading the .env file.

I seized this opportunity to use hyperquest for making HTTP requests to the login server (It will perform better under stress than the http module).

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/241

This is a supporting patch for the makeapi changes - because hyperquest refuses to send a request body with any request that's not POST, I've added a POST handler to `/usernames`

Comment 3

[Scott [:thecount] Downe]

Don't we need to make this: https://github.com/mozilla/MakeAPI/blob/master/env.sample#L2

The same as webmaker.org?

Comment 4

[Chris DeCairos (:cade)]

indeed.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 8381666 [details] [review]
https://github.com/mozilla/MakeAPI/pull/198

Some nits, but nothing critical. It works pretty well.

Comment 6

[Chris DeCairos (:cade)]

Login patch merged: https://github.com/mozilla/login.webmaker.org/commit/211a0591b500a02dfac017c02e0dbedb4397b2e5

Comment 7

[inactivate account for kate]

Comment on attachment 8381666 [details] [review]
https://github.com/mozilla/MakeAPI/pull/198

Fix infinite loop for non-admins, and you should be good.

Comment 8

[inactivate account for kate]

Comment on attachment 8381666 [details] [review]
https://github.com/mozilla/MakeAPI/pull/198

Also, I was not able to delete a make. Received this error message:

{"status":"failure","reason":{"message":"Validation failed","name":"ValidationError","errors":{"ownerApp":{"message":"Validator \"required\" failed for path ownerApp","name":"ValidatorError","path":"ownerApp","type":"required"}}}}

Comment 9

[inactivate account for kate]

Actually the problem was that the make no longer existed/had a bad path.

Comment 10

[inactivate account for kate]

Comment on attachment 8381666 [details] [review]
https://github.com/mozilla/MakeAPI/pull/198

Ok this looks good now, I left 3 comments in the PR you should fix up though

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/543a86015acfca107487e8067239866ec4f7e940
Bug 971848 - Implement new webmaker-auth and remove dependency on node-webmaker-login API in favour of hyperquest