Closed
Bug 971851
Opened 11 years ago
Closed 11 years ago
Implement new Webmaker auth for thimble.webmaker.org
Categories
(Webmaker Graveyard :: Thimble, defect)
Webmaker Graveyard
Thimble
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: cade)
References
Details
(Whiteboard: login2-followup)
Attachments
(2 files)
Once all the new Webmaker auth components are ready, we'll need to implement them in thimble.webmaker.org.
|
||
Updated•11 years ago
|
Whiteboard: login2
|
|
||
Updated•11 years ago
|
Whiteboard: login2 → login2-followup
Attachment #8381586 -
Flags: review?(scott)
Comment on attachment 8381586 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/368
crucially, can you double-check I didn't forget any of the new auth calls for cookie/session parsing, post routes etc?
|
||
Comment 3•11 years ago
|
||
You'll need to env.dist's secret value to be whatever the default is on webmaker.org.
|
|
||
Comment 4•11 years ago
|
||
Still testing, but may have found a bug.
STR:
1. log in via thimble
2. log out in webmaker.org
3. go back to thimble.
Expected: thimble should be logged out.
Actual: it's still logged in.
Could be something wrong with my setup though.
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8381586 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/368
Some comments, it works with a few changes, so I think we're almost there.
Attachment #8381586 -
Flags: review?(scott) → review-
Attachment #8381586 -
Flags: review- → review?
Attachment #8381586 -
Flags: review? → review?(scott)
|
|
||
Comment 6•11 years ago
|
||
Still need to update the default secret value to match webmaker.org's
i am also hitting an issue trying to publish now, but I' have not confirmed if it is me or not yet.
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 8381586 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/368
Need to update session.username to session.user.username, and a rebase for this patch: https://github.com/mozilla/thimble.webmaker.org/commit/88a4366d6de1f315b48d978f2e578e2fc10703a7
Attachment #8381586 -
Flags: review?(scott) → review-
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8381586 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/368
final r? hopefully
Attachment #8381586 -
Flags: review- → review?(scott)
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 8381586 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/368
Final r
Attachment #8381586 -
Flags: review?(scott) → review+
|
|
||
Comment 12•11 years ago
|
||
merged in.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
Assignee | |
Comment 13•11 years ago
|
||
We're missing the domain pref for webmaker-auth
Assignee: pomax → cade
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 14•11 years ago
|
||
Attachment #8385594 -
Flags: review?(jon)
|
|
Reporter | |
Comment 15•11 years ago
|
||
Comment on attachment 8385594 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/374
r+ with one nit
Attachment #8385594 -
Flags: review?(jon) → review+
|
||
Comment 16•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/fed7d68995a63f112995771f2ad6682a016b1fb9
Bug 971851 - Add domain config option for webmaker-auth
|
|
Assignee | |
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•