Implement new Webmaker auth for thimble.webmaker.org

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jon, Assigned: cade)

Tracking

Details

(Whiteboard: login2-followup)

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Once all the new Webmaker auth components are ready, we'll need to implement them in thimble.webmaker.org.
Whiteboard: login2
Whiteboard: login2 → login2-followup

Updated

5 years ago
Assignee: nobody → pomax
Status: NEW → ASSIGNED

Comment 2

5 years ago
Comment on attachment 8381586 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/368

crucially, can you double-check I didn't forget any of the new auth calls for cookie/session parsing, post routes etc?
You'll need to env.dist's secret value to be whatever the default is on webmaker.org.
Still testing, but may have found a bug.

STR:
1. log in via thimble
2. log out in webmaker.org
3. go back to thimble.

Expected: thimble should be logged out.
Actual: it's still logged in.

Could be something wrong with my setup though.
Comment on attachment 8381586 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/368

Some comments, it works with a few changes, so I think we're almost there.
Attachment #8381586 - Flags: review?(scott) → review-

Updated

5 years ago
Attachment #8381586 - Flags: review- → review?

Updated

5 years ago
Attachment #8381586 - Flags: review? → review?(scott)
Still need to update the default secret value to match webmaker.org's

i am also hitting an issue trying to publish now, but I' have not confirmed if it is me or not yet.

Comment 8

5 years ago
updated the default env.dist

Comment 9

5 years ago
and rebased. Will be looking at all the *session* instances.

Comment 12

5 years ago
merged in.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

5 years ago
We're missing the domain pref for webmaker-auth
Assignee: pomax → cade
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 15

5 years ago
Comment on attachment 8385594 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/374

r+ with one nit
Attachment #8385594 - Flags: review?(jon) → review+
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.