971873 - ProxySelector references String.isEmpty(), which is API level 9

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

http://hg.mozilla.org/mozilla-central/annotate/879038dcacb7/mobile/android/base/util/ProxySelector.java#l82 may call String.isEmpty(), which is API level 9 -- a problem for Android 2.2 devices. Maybe TextUtils.isEmpty() should be used instead?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: proxy-textutils v0.1

Using TextUtils.isEmpty

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8375970 [details] [diff] [review]
proxy-textutils v0.1

Review of attachment 8375970 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/util/ProxySelector.java
@@ +80,5 @@
>       * null.
>       */
>      private Proxy lookupProxy(String hostKey, String portKey, Proxy.Type type, int defaultPort) {
>          String host = System.getProperty(hostKey);
> +        if (host == null || TextUtils.isEmpty(host)) {

`host == null` check is redundant since isEmpty looks for null or empty string.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Updated to remove the null check
https://hg.mozilla.org/integration/fx-team/rev/4f2fe6efed84

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f2fe6efed84