971900 - onLocaleReady incorrectly elides onConfigurationChange call if urlBar doesn't exist

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

// The URL bar hint needs to be populated.
       TextView urlBar = (TextView) findViewById(R.id.url_bar_title);
       if (urlBar == null) {
           return;
       }
       final String hint = getResources().getString(R.string.url_bar_default_text);
       urlBar.setHint(hint);

       // Allow onConfigurationChanged to take care of the rest.
       onConfigurationChanged(getResources().getConfiguration());

That early return is probably a little over-zealous.

Comment 1

[Richard Newman [:rnewman]]

Attachment: onLocaleReady incorrectly elides onConfigurationChange call if urlBar doesn't exist. v1

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8407219 [details] [diff] [review]
onLocaleReady incorrectly elides onConfigurationChange call if urlBar doesn't exist. v1

Review of attachment 8407219 [details] [diff] [review]:
-----------------------------------------------------------------

A comment explaining that |onLocaleReady| is for strings, whilst |onConfigurationChanged| is for device changes (that might not require strings) in the method comments of each would be good.

Also, a log if urlBar doesn't exist?  I'm not sure how scared I should be that having urlBar in GeckoApp is not a hard requirement...

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/358d667d091b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/358d667d091b