Closed Bug 971940 Opened 10 years ago Closed 10 years ago

'unicode' is not a type we can check something is NOT

Categories

(Socorro :: Webapp, task)

Product:
Socorro
Component:
Webapp
Platform:
x86
macOS
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: peterbe, Assigned: peterbe)

Details

In the GCCrashes model, we require `product` and `version`. These are coded as `unicode` as a required type. 
https://crash-stats.mozilla.com/api/#GCCrashes

This does not make sense because there's nothing in python that can NOT become a unicode. So there's no point enforcing its type.
It was my mistake not noticing it in review.
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ef180e818afd44ef793d9ffd2570883dedcc5084
fixes bug 971940 - 'unicode' is not a type we can check something is NOT, r=rhelmer
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 75
You need to log in before you can comment on or make changes to this bug.