971969 - Add a required field to curated groups: "Criteria for Joining"

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

A discussion on the community builder's list[0] included a suggestion to ask Curators to explain what the criteria would be for accepting membership requests. Let's build a required field: "What criteria will you use to evaluate membership requests" (wordsmithing welcome). 

For this field, "none" will be a perfectly fine answer, but "" will not.

We can display this criteria in the group's information box alongside other information about the group.

[0] https://mail.mozilla.org/pipermail/community-building/2014-February/001198.html

Comment 1

[William Reynolds [:williamr]]

(In reply to Justin Crawford [:hoosteeno] from comment #0)
> A discussion on the community builder's list[0] included a suggestion to ask
> Curators to explain what the criteria would be for accepting membership
> requests. Let's build a required field: "What criteria will you use to
> evaluate membership requests" (wordsmithing welcome). 

I like this idea.

Will this field be required only if the group is set to accepting members 'by request only'? I don't think we need a criteria field for groups where the membership is open.

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Yes that makes sense for groups which moderate memberships.

Comment 3

[Jeff Potts]

Making progress on this if you want to take a look. Added a new field to capture the criteria. Also added a clean method to the SuperuserGroupForm to validate that the criteria is not blank when memberships are moderated.

In edit mode I added the field to its own fieldset though I initially put it in the same fieldset as the moderation dropdown. It didn't look right so I moved it.

Remaining work is to add the client-side JavaScript necessary to hide/display the field depending on the value of the moderation dropdown and to make the criteria show up on the read mode group page.

Comment 4

[Jeff Potts]

https://github.com/jpotts/mozillians/tree/fix_971969

Comment 5

[Jeff Potts]

This is complete. Created a pull request: https://github.com/mozilla/mozillians/pull/819

Tried to squash into a single commit but it is showing as six commits. Let me know if I need to fix that.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

Thanks for the pull request Jeff. I'll reply in github with review comments.

Comment 7

[Jeff Potts]

Incorporated your feedback and created a new pull request: https://github.com/mozilla/mozillians/pull/827

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/0c0f5266820dac078086b318c0702a4ac06410c1
[Fix bug 971969] Add new member criteria field

Comment 9

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: new criteria field

There are a couple issues I'd like to resolve before we launch this one:

1) There's no required indicator (*) on the criteria field

2) The error message on the field wraps oddly

See attached.

Fixing the first is probably a hack, since normal field helpers might not apply here. Fixing the second might just be a matter of forcing a line break in the middle or constraining the text within a width-limited container.

Comment 10

[William Reynolds [:williamr]]

(In reply to Justin Crawford [:hoosteeno] from comment #9)
> There are a couple issues I'd like to resolve before we launch this one:

I have one more enhancement suggestion. Let's left align the 'member criteria' text area with the 'accepting new members' dropdown box. This would be consistent with how we align form elements on other pages.

This field looks great - thanks Jeff!

Comment 11

[Jeff Potts]

I will look at the other pages to figure out how to left align those two fields.

Regarding the required indicator, there is a helper called mozillians_field that gets the template used to create field labels and fields. What if we add an argument to mozillians_field, like force_required, which would default to False. The flag would be passed to the template in the context. The template could then turn on the required indicator if the flag is true. Just brainstorming here, open to other ideas, of course.

Regarding the validation error message wrap, I agree it looks bad. Maybe all text areas should display error text on a new line below the field? Not sure how to do that offhand, but I'm just thinking this probably won't be the last time it will come up.

Comment 12

[Jeff Potts]

Just checked in some attempts to address a couple of these enhancement requests. 

On the error message, I added max-width:200px; display:inline-block; to .error-message. That fixes that particular error message and doesn't seem to adversely impact any others.

On the required indicator, I implemented what I described above on 2/27.

Comment 13

[Giorgos Logiotatidis [:giorgos]]

Jeff it would be great if you could complete this today (Wed 5). Always happy to help you if you're busy. Let me know.

Thanks!

Comment 14

[Jeff Potts]

This needs your attention. I think it is close and probably ready to go as-is, but it is your call. The required indicator makes the two fields line up nearly perfectly. If that's not good enough I'm not sure what the best approach is. Needs a CSS person.

Comment 15

[Giorgos Logiotatidis [:giorgos]]

Jeff you forgot to pull request! :)

You had the code in your repository and I created a pull request for you with minor changes on the css side.
https://github.com/mozilla/mozillians/pull/847

Thanks for working on this!

Comment 16

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/115c83741a4c4b3b95261e37ce25cf72932bd87c
[fix bug 971969] Fix criteria error message and required indicator.

https://github.com/mozilla/mozillians/commit/1325ef2ac1df63e869b0db0583490e648c12a886
Merge pull request #847 from glogiotatidis/971969_3

[fix bug 971969] Fix criteria error message and required indicator.

Comment 17

[Justin Potts [:justinpotts]]

Attachment: QA - verified on stage

Creating a new group and selecting "By request" for new members creates a text box. It does not create the group until it contains text or is changed to "No" or "Yes." Creating the group displays the text in the group description as requested.