Closed Bug 972038 Opened 10 years ago Closed 10 years ago

Stop using GetMessageMoz in nsConsoleService::LogMessageWithMode

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: bzbarsky, Assigned: JustinShrake)

Details

(Whiteboard: [mentor=bzbarsky@mit.edu][good first bug][lang=c++])

Attachments

(1 file)

Initial patch for Bug 972038
2.16 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
Just use ToString instead.  All the callers here want UTF-8 anyway, so that will save on some conversions/allocations.
Whiteboard: [mentor=bz][lang=c++]
Whiteboard: [mentor=bz][lang=c++] → [mentor=bzbarsky@mit.edu][good first bug][lang=c++]
Can I be assigned this bug? I've identified the issue in the code and should have a patch in the next few days.
Absolutely!  Thank you for working on this.
Assignee: nobody → JustinShrake
I did not make any changes to the XP_WIN block as this caller is not converting to UTF-8. Bug 969762 seems relevant.
Attachment #8376017 - Flags: review?(jmathies)
Attachment #8376017 - Flags: review?(jmathies) → review+
Whiteboard: [mentor=bzbarsky@mit.edu][good first bug][lang=c++] → [mentor=bzbarsky@mit.edu][good first bug][lang=c++][checkin-needed]
Keywords: checkin-needed
Whiteboard: [mentor=bzbarsky@mit.edu][good first bug][lang=c++][checkin-needed] → [mentor=bzbarsky@mit.edu][good first bug][lang=c++]
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecd5c56ed519

Please use your full name in your Hg commit info :)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ecd5c56ed519
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: