Spectrum.js warning in browser console `test for equality (==) mistyped as assignment (=)?`

VERIFIED FIXED in Firefox 30

Status

VERIFIED FIXED
5 years ago
6 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

Trunk
Firefox 30

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Open devtools on the debugger tab - this error shows up in browser console:

`test for equality (==) mistyped as assignment (=)?` Spectrum.js:139
(Assignee)

Comment 1

5 years ago
Created attachment 8375641 [details] [diff] [review]
assignment-warning.patch
Attachment #8375641 - Flags: review?(jwalker)
Comment on attachment 8375641 [details] [diff] [review]
assignment-warning.patch

Review of attachment 8375641 [details] [diff] [review]:
-----------------------------------------------------------------

Presumably we don't have a problem keeping this in sync with the original?
Attachment #8375641 - Flags: review?(jwalker) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Joe Walker [:jwalker] from comment #2)
> Comment on attachment 8375641 [details] [diff] [review]
> assignment-warning.patch
> 
> Review of attachment 8375641 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Presumably we don't have a problem keeping this in sync with the original?

Yes, it has diverged enough that there isn't a need to keep changes in sync.
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/f095cf2a41b2
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f095cf2a41b2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Verified with latest build of Nightly
Status: RESOLVED → VERIFIED

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.