972141 - Some more GA events in popcorn maker

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

First round is on staging, testing it out now.

Seems the project ended event never gets fired, or I don't know how to view non interaction events.

The other issue is we're not logging the type of track event added, but instead the how.

Not sure if this should be a new event, maybe? EventType added maybe?

Also, more of the events from here: https://etherpad.mozilla.org/webmaker-ga-events-naming-convention

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/455

So looks like we only caught events from the editor for play and ended.

Updated that.

I also noticed our play events happened on not just clicks, but any play, so autoplay, play from a seekn as examples.

I fixed this so it only happens on the actual clicks.

I also noticed it would be interesting to track clicks to the big play button.

Comment 2

[Adam Lofting (:adamlofting)]

Comment on attachment 8375593 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/455

Nice work on the GA tags.
I'm not 100% clear on the general JS logic in here, so it might be worth a pair of eyes from someone who knows the general code better than me?

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 8375593 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/455

Updated

Comment 4

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/5d3944552e7a5c1bfa3ddcb497071db4dd564cfb

Needs verification.