Closed Bug 972150 Opened 6 years ago Closed 6 years ago

[DSDS][Gaia][Sim Manager] support always ask feature

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: eragonj, Assigned: eragonj)

References

Details

Attachments

(1 file)

In 1.4, we have to add one more feature which is `always ask` option on `outgoing call` and `outgoing message` select.
Blocks: 946866
Comment on attachment 8375375 [details] [review]
patch

Hi Anthony,

Not sure whether this change is ok for you or not, so I may need your feedback for this patch.

Thanks :)
Attachment #8375375 - Flags: feedback?(anthony)
(In reply to EJ Chen [:eragonj][:小龍哥] from comment #2)
> Comment on attachment 8375375 [details] [review]
> patch
> 
> Hi Anthony,
> 
> Not sure whether this change is ok for you or not, so I may need your
> feedback for this patch.
> 
> Thanks :)

Please apply this patch to test your related works on dialer app ! Thanks :)
Target Milestone: --- → 1.4 S2 (28feb)
Comment on attachment 8375375 [details] [review]
patch

I haven't written code that uses those settings yet so I can't really say it works for us. I think it should be ok.

needinfo-ing Doug who has some code locally.
Flags: needinfo?(drs+bugzilla)
(In reply to Anthony Ricaud (:rik) from comment #4)
> Comment on attachment 8375375 [details] [review]
> patch
> 
> I haven't written code that uses those settings yet so I can't really say it
> works for us. I think it should be ok.
> 
> needinfo-ing Doug who has some code locally.

Yeah ok ! Thanks for your quick response. Let's wait Doug's comments !
Attachment #8375375 - Flags: feedback?(anthony)
I just tried this, and it worked great for me! Thanks for this patch.
Flags: needinfo?(drs+bugzilla)
(In reply to Doug Sherk (:drs) from comment #6)
> I just tried this, and it worked great for me! Thanks for this patch.

Thanks Doug ! 

I would start the reviewing process for the patch !! :P
Comment on attachment 8375375 [details] [review]
patch

Hey Arthur,

this patch is finally ready for reviewing ! 

As you may see, Doug has tested this patch and works well for them. Besides, I also get green from Travis ! 

Please help me review this ~50 lines patch :)

Big thanks !!!!
Attachment #8375375 - Flags: review?(arthur.chen)
Comment on attachment 8375375 [details] [review]
patch

r=me. Thanks!
Attachment #8375375 - Flags: review?(arthur.chen) → review+
Thanks Arthur & all, 

this patch was merged on Gaia/master : 691651a19cad6ed6731f0a234f70fe5da2ff3bae
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.