972161 - Fix font recording when using freetype fonts

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Record font data freetype fonts

We need to properly record font data for FreeType fonts.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8375281 [details] [diff] [review]
Record font data freetype fonts

Review of attachment 8375281 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/ScaledFontBase.cpp
@@ +220,5 @@
> +	cairo_ft_scaled_font_unlock_face(mScaledFont);
> +	return false;
> +      }
> + 
> +      FT_ULong length = 0;

// get the length of the whole font

@@ +228,5 @@
> +	gfxWarning() << "Failed to get font file from Freetype font. " << error;
> +	return false;
> +      }
> +      
> +      std::vector<FT_Byte> buffer(length);

// get the data

@@ +244,5 @@
> +  }
> +#endif
> +  
> +  return false;
> +}

This function could use some whitespace cleanup (Take a look at the review pane)

Comment 2

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c2869f48842d for Windows warnings-as-errors bustage, https://tbpl.mozilla.org/php/getParsedLog.php?id=34602124&tree=Mozilla-Inbound