Closed
Bug 972161
Opened 10 years ago
Closed 3 years ago
Fix font recording when using freetype fonts
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: bas.schouten, Assigned: bas.schouten)
Details
Attachments
(1 file)
3.87 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
We need to properly record font data for FreeType fonts.
Attachment #8375281 -
Flags: review?(jmuizelaar)
Comment 1•10 years ago
|
||
Comment on attachment 8375281 [details] [diff] [review] Record font data freetype fonts Review of attachment 8375281 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/ScaledFontBase.cpp @@ +220,5 @@ > + cairo_ft_scaled_font_unlock_face(mScaledFont); > + return false; > + } > + > + FT_ULong length = 0; // get the length of the whole font @@ +228,5 @@ > + gfxWarning() << "Failed to get font file from Freetype font. " << error; > + return false; > + } > + > + std::vector<FT_Byte> buffer(length); // get the data @@ +244,5 @@ > + } > +#endif > + > + return false; > +} This function could use some whitespace cleanup (Take a look at the review pane)
Attachment #8375281 -
Flags: review?(jmuizelaar) → review+
Comment 2•10 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c2869f48842d for Windows warnings-as-errors bustage, https://tbpl.mozilla.org/php/getParsedLog.php?id=34602124&tree=Mozilla-Inbound
Assignee | ||
Updated•3 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•