Allow user to put a bookmark in a folder from edit bookmark dialog

RESOLVED DUPLICATE of bug 1329131

Status

()

Firefox for Android
Awesomescreen
P3
normal
RESOLVED DUPLICATE of bug 1329131
4 years ago
11 months ago

People

(Reporter: rnewman, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments)

(Reporter)

Description

4 years ago
I've seen a number of power user complaints lately about Fennec's inability to put bookmarks in folders or allow for rearranging bookmarks on the device. 

This seems particularly relevant to tablet users, especially those who don't have a primary desktop. 

I've even noticed this restriction myself: I find myself shuffling pages into Pocket or using Send Tab so I will (I hope!) remember to bookmark them on my desktop, because I don't want them hidden away in Mobile Bookmarks.

Now might be the time to consider speccing out this work.
We've definitely been thinking about this. 

- Creating bookmarks folders
- Choosing what folder in which to save a bookmark
- Moving bookmarks around
- Even tagging bookmarks with keywords and making them searchable

Actually ties in nicely with your share handler bug 948509. Not only would it be great to save a page into Firefox, it would also be great to let users be very specific about where they want that bookmark to go.
- Sort?
Also sort, yes.

Comment 4

4 years ago
This looks like a dupe of bug 762298.
(Reporter)

Updated

4 years ago
Duplicate of this bug: 762298
(Reporter)

Comment 6

4 years ago
(In reply to :Margaret Leibovic from comment #4)
> This looks like a dupe of bug 762298.

Well spotted, Margaret! I duped it forward 'cos there's more here.


(In reply to Ian Barlow (:ibarlow) from comment #1)

> Actually ties in nicely with your share handler bug 948509. Not only would
> it be great to save a page into Firefox, it would also be great to let users
> be very specific about where they want that bookmark to go.

Yeah, that was very much on my mind.

Updated

4 years ago
Duplicate of this bug: 768128
(Reporter)

Comment 8

4 years ago
Another thought: I just bookmarked something on desktop. My destination folder wasn't one of my most recents, so I had to go browsing through a janky (XUL) tree view. This bugs me every time, because I have this giant screen and a tiny picker which never has the folder I want.

Compare and contrast to Todoist on desktop. When you assign a task to a project, you get a scrollable treeview (not really a tree, actually just an indented list) and a search field at the top. You get type-ahead filtering on your project tree. Usually I only have to hit one or two keys to get the result I want.

This is something to consider for bookmarking, I think. Typing on mobile sucks, but searching through a data structure by hand sucks more.
(Reporter)

Comment 9

4 years ago
Created attachment 8376073 [details]
Type-ahead find, showing structure

Updated

4 years ago
Blocks: 1009373
There's also bug 795331, which can probably be duped to this. Still hope to see this someday!
(Reporter)

Comment 11

4 years ago
(In reply to Aaron Train [:aaronmt] from comment #10)
> There's also bug 795331, which can probably be duped to this.

I think blocks, not dupes. There are lots of reasons why users have trouble with bookmarks in Fennec, and folderizing mobile-created bookmarks isn't the only one!
Blocks: 795331

Comment 12

4 years ago
Ideally, such a feature would not only include creating bookmark folders, but also deleting and renaming bookmark folders.

Comment 13

3 years ago
This is desperately needed. For me personally, this browser just isn't practical without any bookmarks management. Or very basic ability to add folders and sub folders for organising bookmarks. I'm sure I'm not the only one who meticulously organises huge numbers of bookmarks (5k plus) in proper folders and sub folders. Without it, it is literally a nightmare to use efficiently.
Blocks home panels refinements, at least per the current design.
Blocks: 1063058

Updated

3 years ago
Blocks: 1126441

Updated

3 years ago
No longer blocks: 1126441

Updated

3 years ago
Blocks: 1126441
Hey all!
Does the mobile team have some plan to work on this anytime soon?
I would really love to help :)
There are no plans, if there were they would be posted here. Nontheless this would need interaction decisions. I've CC'ed Anthony to this bug to maybe provide some thought.

Comment 17

3 years ago
Check Chrome's bookmark management implementation on Android. It's far from perfect, but allows you to move bookmarks to other folders by long pressing on them and choosing to edit them (you can also create new folders from there). If you long press a folder you can rename it or delete it. Those are all things currently not possible on Firefox for Android. You should implement it, even if just for the sake of feature parity.
Perhaps a good place to start would be to leverage dialogs as much as we can and allow users basic "move to folder A" ability? Essentially, Long=press > Edit > See and press "Folder" > choose "Folder A" from dialog list.

I know Chrome has also been working on a new Bookmarks management UI that resembles cards UI a bit more as well.
Duplicate of this bug: 1201815
Duplicate of this bug: 1216208

Comment 21

3 years ago
(In reply to Anthony Lam (:antlam) from comment #18)
> Perhaps a good place to start would be to leverage dialogs as much as we can
> and allow users basic "move to folder A" ability? Essentially, Long=press >
> Edit > See and press "Folder" > choose "Folder A" from dialog list.

Indeed, this would be a good start to reduce the accumulated clutter from the bookmarks tab and a step forward towards better UI interaction and usability.
Created attachment 8698158 [details]
prev_bookmarks_bookmarkmgmt_L2_4.png

For basic folder "moving" capabilities, I think the best choice would be to go with a full page dialog that triggers after a user does one of the following: 

A) long-press on a Bookmark > sees dialog > presses "Edit"
B) user presses on menu > sees filled star > presses on filled star

Pressing the folder will show a list of folders available and pressing on one will just move it there. We can also give feedback with a snackbar (w/ undo).

Updated

2 years ago
Assignee: nobody → ahunt

Updated

2 years ago
Blocks: 1232437

Comment 23

2 years ago
Let's keep this bug simple, and use bug 1232437 to track other parts of this bookmark folder work.
Summary: Allow folder management in Fennec bookmarks UI → Allow user to put a bookmark in a folder from edit bookmark dialog

Updated

2 years ago
No longer blocks: 795331

Updated

2 years ago
No longer blocks: 1009373

Updated

2 years ago
No longer blocks: 1126441

Updated

2 years ago
No longer blocks: 1063058

Comment 24

2 years ago
Just to clarify do we want to implement the folder selection as an additional dialog that appears when the user selects "Folder", or expand a folder selection view as part of the dialog, or in some other way?

Either way, think I should probably fix Bug 1232439 (convert to fullscreen dialog) before starting on this - I'm not sure how much work that will involve, but it's probably easier to do that before adding more functionality to the dialog.
Depends on: 1232439

Comment 25

2 years ago
Created attachment 8718101 [details]
editbookmark_folder.png

(In reply to Andrzej Hunt :ahunt from comment #24)
> Just to clarify do we want to implement the folder selection as an
> additional dialog that appears when the user selects "Folder", or expand a
> folder selection view as part of the dialog, or in some other way?

I was talking with Margaret about this earlier - I'm not sure what a sensible way for doing folder selection is, some of the options we talked about were:

- Show a (fullscreen, or dialog) navigable hierarchy, i.e. like what we show in the Bookmarks Panel, where we can navigate through folders. We'd need to add some way of selecting the desired folder, e.g. a checkmark beside the folder name, or a button to set the currently opened folder as the folder for the bookmark?

- Show a flat list of all folders - this could even be in a scrollable dropdown. We could run into issues if we have multiple folders with the same name, since there's no way to distinguish them, unless we also show the full folder path. This could also be searchable, like gmails label selector?

I started prototyping how the first version would look, but haven't done much beyond showing the current folder in the edit-bookmark dialog (screenshot attached - the spacing/alignment is a bit messed up right now)
Flags: needinfo?(alam)
No longer blocks: 1251314

Comment 26

2 years ago
Created attachment 8737325 [details]
MozReview Request: [WIP] Bug 972193 - Part 1: introduce BrowserDB.getBookmarkFolders

Review commit: https://reviewboard.mozilla.org/r/43897/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43897/
Created attachment 8755948 [details]
prev_bookmarks_bookmarkmgmt_L2_4.png

(In reply to Andrzej Hunt :ahunt from comment #25)
> Created attachment 8718101 [details]
> editbookmark_folder.png
> 
> (In reply to Andrzej Hunt :ahunt from comment #24)
> > Just to clarify do we want to implement the folder selection as an
> > additional dialog that appears when the user selects "Folder", or expand a
> > folder selection view as part of the dialog, or in some other way?

A simple dialog is what I was thinking (when a user selects "Folder" from within the "Edit bookmark" full page dialog).

Here's mock of what the "Edit bookmark" full page dialog looks like in my head right now (I omitted "keywords" in the mock but don't worry about that for now).
Flags: needinfo?(alam)
Created attachment 8755949 [details]
prev_bookmarks_movefolder.png

> - Show a (fullscreen, or dialog) navigable hierarchy, i.e. like what we show
> in the Bookmarks Panel, where we can navigate through folders. We'd need to
> add some way of selecting the desired folder, e.g. a checkmark beside the
> folder name, or a button to set the currently opened folder as the folder
> for the bookmark?
> 
> - Show a flat list of all folders - this could even be in a scrollable
> dropdown. We could run into issues if we have multiple folders with the same
> name, since there's no way to distinguish them, unless we also show the full
> folder path. This could also be searchable, like gmails label selector?
> 
> I started prototyping how the first version would look, but haven't done
> much beyond showing the current folder in the edit-bookmark dialog
> (screenshot attached - the spacing/alignment is a bit messed up right now)

Here's a WIP mock of the "simple dialog" I was referring to earlier.

While this is a work-in-progress, I think some indenting will solve issues around folder structure, and an icon can help denote hierarchy.

Comment 29

2 years ago
Unassigning since I'm not actively looking into this right now,.
Assignee: ahunt → nobody
Priority: -- → P3

Comment 30

2 years ago
New user, finally moved over from Chrome. This feature would honestly be the biggest reason for me to move permanently. Until now I've been using Xmarks which hasn't been developed since LastPass acquired it; I can use this with Firefox same as Chrome by sharing links to it, but it has a flat folder selection which absolutely causes problems when there are dupes e.g.

restaurants > europe > spain, and
travel > europe > spain

Possibly something like Astro File Manager's 'move file' implementation, which would reuse the existing bookmark folder navigation but simply add a bottom bar with "move" and "cancel". I guess this would mean the screen height available for the bookmarks part would have to be artificially reduced by the heights of the move/cancel bar.

Comment 31

2 years ago
I think this is a big limitation on the way of equality between smartphone and desktop or laptop. I hope you will resolve this issue.
(Reporter)

Comment 32

a year ago
My current recommendation for desktop, btw:

https://addons.mozilla.org/firefox/addon/quickmark/

Comment 33

11 months ago
It looks like we got duped (I believe this is behind a flag, so it's probably not visible in nightly at this time).
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1329131
You need to log in before you can comment on or make changes to this bug.