Setting dialog caption using window.title doesn't work

VERIFIED FIXED in M9

Status

()

P3
normal
VERIFIED FIXED
20 years ago
19 years ago

People

(Reporter: cmanske, Assigned: hyatt)

Tracking

Trunk
All
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

20 years ago
According to danm, the correct way to change the window caption or "title"
at runtime is document.title="My Title".
This currently yields a not-implemented error message.
(Reporter)

Comment 1

20 years ago
David Hyatt noted that using document.title will append "-Mozilla" onto the
title. We understand about the security issue here, but that shouldn't be done
if the title is being set from a chrome shell. Having "-Mozilla" would look
very ugly on all our dialogs.

Updated

20 years ago
Status: NEW → ASSIGNED
Target Milestone: M9
(Reporter)

Comment 2

20 years ago
Talk to hyatt and danm about this. I agree with their assesment that this
should really be a method on the window, not the document, when used for
a dialog caption. (The window has the "title" attribute that you set in the
XUL file now.)

Comment 3

20 years ago
Added myself to cc list.  I need this for two of the address book dialogs.

Comment 4

20 years ago
Yes the window does have a title that you can set from XUL.  However it does not
seem to work from JS.

Comment 5

20 years ago
Added danm to the cc: list in hopes that he'll take the bug :-)

Comment 6

20 years ago
Based on this thread:

news://news.mozilla.org/378D4321.40541BB3%40netscape.com

it seems like we should probably mark this bug as INVALID. Hyatt should
have window.title working RSN.

Charlie, does that sound okay?
(Reporter)

Updated

20 years ago
Assignee: waterson → hyatt
Status: ASSIGNED → NEW
Summary: Setting window caption using document.title is not implemented → Setting window caption is not implemented
(Reporter)

Comment 7

20 years ago
I just reassigned it so David will have a bug to mark fixed :)
(Assignee)

Updated

20 years ago
Status: NEW → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

20 years ago
Fixed.  Use window.title.
(Reporter)

Updated

20 years ago
Status: RESOLVED → REOPENED
(Reporter)

Comment 9

20 years ago
Thanks for your quick response, but unfortunately it isn't setting the title
in a dialog in the onload handler. I think its a timing/redraw issue. If I
break in your new code, everything looks great. But I noticed that the window
already displayed just before it hit the break point. I'm setting it in the
dialog's onload hander ("Startup()"), so as with autosizing to content
not responding to adding content, it is displayed too early?
To test it:
1. Load editor
2. Click on Table toolbar button (caret will be in the "Number of rows"
editbox
3. Delete the default "1" and type "0"
4. Click OK
This will cause an error dialog to display. The dialog caption should be
"Input Error", not "Netscape"

Updated

20 years ago
Resolution: FIXED → ---

Comment 10

20 years ago
Clearing Fixed resolution due to ReOpen of this bug.
(Reporter)

Updated

20 years ago
Status: REOPENED → ASSIGNED
Summary: Setting window caption is not implemented → Setting dialog caption using window.title doesn't work
(Assignee)

Comment 11

20 years ago
I can't test this bug, since the table dialog's text input fields won't let me
change the values, and since the Ok/Cancel buttons don't appear to be present on
the dialog (which is coming up at a ridiculous size).
(Assignee)

Updated

20 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 20 years ago20 years ago
Resolution: --- → FIXED
(Assignee)

Comment 12

20 years ago
Fixed.  SetTitleFromXUL was buggy.

Comment 13

20 years ago
ermmm, following the steps from charlie's comment on 07/16/99
still results in an error dialog with the title 'Netscape'

what to do?
(Assignee)

Comment 14

20 years ago
I think it works.  Let's wait until cmanske gets back from vacation, and he can
verify.

Comment 15

19 years ago
Sorry for spam, re-assigning phillip's QA contact XPToolkit/XPWidget bugs to
claudius due to restructure

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 16

19 years ago
cmanske, I'm thinking this is okay, let me know if I'm wrong
You need to log in before you can comment on or make changes to this bug.