9722 - Setting dialog caption using window.title doesn't work

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Charles Manske]

According to danm, the correct way to change the window caption or "title"
at runtime is document.title="My Title".
This currently yields a not-implemented error message.

Comment 1

[Charles Manske]

David Hyatt noted that using document.title will append "-Mozilla" onto the
title. We understand about the security issue here, but that shouldn't be done
if the title is being set from a chrome shell. Having "-Mozilla" would look
very ugly on all our dialogs.

Comment 2

[Charles Manske]

Talk to hyatt and danm about this. I agree with their assesment that this
should really be a method on the window, not the document, when used for
a dialog caption. (The window has the "title" attribute that you set in the
XUL file now.)

Comment 3

[hangas]

Added myself to cc list.  I need this for two of the address book dialogs.

Comment 4

[hangas]

Yes the window does have a title that you can set from XUL.  However it does not
seem to work from JS.

Comment 5

[Chris Waterson]

Added danm to the cc: list in hopes that he'll take the bug :-)

Comment 6

[Chris Waterson]

Based on this thread:

news://news.mozilla.org/378D4321.40541BB3%40netscape.com

it seems like we should probably mark this bug as INVALID. Hyatt should
have window.title working RSN.

Charlie, does that sound okay?

Comment 7

[Charles Manske]

I just reassigned it so David will have a bug to mark fixed :)

Comment 8

[David Hyatt]

Fixed.  Use window.title.

Comment 9

[Charles Manske]

Thanks for your quick response, but unfortunately it isn't setting the title
in a dialog in the onload handler. I think its a timing/redraw issue. If I
break in your new code, everything looks great. But I noticed that the window
already displayed just before it hit the break point. I'm setting it in the
dialog's onload hander ("Startup()"), so as with autosizing to content
not responding to adding content, it is displayed too early?
To test it:
1. Load editor
2. Click on Table toolbar button (caret will be in the "Number of rows"
editbox
3. Delete the default "1" and type "0"
4. Click OK
This will cause an error dialog to display. The dialog caption should be
"Input Error", not "Netscape"

Comment 10

[leger]

Clearing Fixed resolution due to ReOpen of this bug.

Comment 11

[David Hyatt]

I can't test this bug, since the table dialog's text input fields won't let me
change the values, and since the Ok/Cancel buttons don't appear to be present on
the dialog (which is coming up at a ridiculous size).

Comment 12

[David Hyatt]

Fixed.  SetTitleFromXUL was buggy.

Comment 13

[phillip]

ermmm, following the steps from charlie's comment on 07/16/99
still results in an error dialog with the title 'Netscape'

what to do?

Comment 14

[David Hyatt]

I think it works.  Let's wait until cmanske gets back from vacation, and he can
verify.

Comment 15

[Paul MacQuiddy]

Sorry for spam, re-assigning phillip's QA contact XPToolkit/XPWidget bugs to
claudius due to restructure

Comment 16

[Paul MacQuiddy]

cmanske, I'm thinking this is okay, let me know if I'm wrong