972265 - Use adaptive delays when trying to reconnect socket

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

On my Hamachi, rild constantly disconnects; probably because of incompatibilities with Gecko's RIL code. Currently, Gecko tries to reconnect after 1 second, but this just fills the logcat with warnings.

A good delay for re-connects would adapt to the symptoms. So the more often the connect operation fails, the longer the delay gets. And for transient failures the delay should still remain short.

This should also handle a similar problem on systems where nfcd wasn't running. Gecko tried to connect to nfcd every second, and failed on each attempt.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 972265: Maintain connect delay in UnixSocketConsumer

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 972265: Use connect delay in RIL IPC code

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 972265: Use connect delay in NFC IPC code

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #1)
> Created attachment 8375441 [details] [diff] [review]
> [01] Bug 972265: Maintain connect delay in UnixSocketConsumer

The gecko socket get's disconnected because rilproxy closes it's end when rild disconnects. I'm also working on a similar patch to improve the situation in rilproxy.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

A follow-up for netd?  On Kitkat, netd initialization takes a few seconds longer especially in emulator. Current MAX_RECONNECT_TIMES=10 scheme gives only a 10 second window and sometimes netd just can't catch the last train.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #5)
> A follow-up for netd?  On Kitkat, netd initialization takes a few seconds
> longer especially in emulator. Current MAX_RECONNECT_TIMES=10 scheme gives
> only a 10 second window and sometimes netd just can't catch the last train.

This could certainly be used for netd, but should be a separate bug.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://hg.mozilla.org/integration/b2g-inbound/rev/47d5e2be3d17
https://hg.mozilla.org/integration/b2g-inbound/rev/1d1bbffa3b9f
https://hg.mozilla.org/integration/b2g-inbound/rev/7736936437ba

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=7736936437ba

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/47d5e2be3d17
https://hg.mozilla.org/mozilla-central/rev/1d1bbffa3b9f
https://hg.mozilla.org/mozilla-central/rev/7736936437ba