Remove the "→" from networkMenu.totalMS

RESOLVED FIXED in Firefox 64

Status

P3
normal
RESOLVED FIXED
5 years ago
5 months ago

People

(Reporter: vporof, Assigned: aburone)

Tracking

unspecified
Firefox 64

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
It's just noise. We should really remove it.

Updated

9 months ago
Product: Firefox → DevTools
(Assignee)

Comment 1

6 months ago
Posted patch Bug972284.patch (obsolete) — Splinter Review
Attached a patch file to fix the bug. I was unable to submit to phabricator for review
(Reporter)

Comment 2

6 months ago
Comment on attachment 9014901 [details] [diff] [review]
Bug972284.patch

Review of attachment 9014901 [details] [diff] [review]:
-----------------------------------------------------------------

I think we also need to update the localisation id as well, so that localisers update this for every language.
(Assignee)

Comment 3

6 months ago
(In reply to Victor Porof [:vporof][:vp] from comment #2)
> Comment on attachment 9014901 [details] [diff] [review]
> Bug972284.patch
> 
> Review of attachment 9014901 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think we also need to update the localisation id as well, so that
> localisers update this for every language.

I have no idea what that id is. That's my first time with Firefox code, sorry.
I figured It should be localized, but don't know the procedure to reach to the localizers.
(Reporter)

Comment 4

6 months ago
That's "networkMenu.totalMs", should change it to something like "networkMenu.totalMs2"
(Assignee)

Comment 5

6 months ago
Posted patch 972284.patchSplinter Review
Done, new patch
Tried to install a language pack to see which error this would create but can't override the version check
(Reporter)

Comment 6

6 months ago
Comment on attachment 9014997 [details] [diff] [review]
972284.patch

Review of attachment 9014997 [details] [diff] [review]:
-----------------------------------------------------------------

Don't worry, localisers will pick that up.

Looks good to me. Should push to try first to see if there's any tests that fail, r+ if green.
Attachment #9014997 - Flags: review+
Nice, thanks!

@Ariel, don't forget to:

1) Mark the old patch as obsolete (Details -> Edit Details -> Check Obsolete checkbox)
2) Set checkin-needed into the Keywords list (use the blue Edit button at the top) if try is green

Try push results here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=37b80b62257fd261d12f1c28be9803c775710396
(there should be no failures)

Honza
Flags: needinfo?(aburone)
Try looks good.

@Ariel, the next step is to add `checkin-needed` keyword so sheriffs can land the patch into the m-c (Mozilla Central) repo.

1) Click the Blue Edit Bug button at the top
2) See the Tracking -> Keywords input field
3) Add checkin-needed
4) Click Save Changes (blue button)

Thanks for the help!

Honza
(Assignee)

Updated

6 months ago
Attachment #9014901 - Attachment is obsolete: true
Flags: needinfo?(aburone)
Adding checkin-needed keyword since Ariel doesn't seem to have enough privileges.

Honza
Assignee: nobody → aburone
Status: NEW → ASSIGNED
Keywords: checkin-needed
Priority: -- → P3

Comment 10

6 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9293f334a994
"Remove the "→" from networkMenu.totalMS" r=vporof
Keywords: checkin-needed

Comment 11

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9293f334a994
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.