972418 - Can't create a SREG from the command line (plus bug in error reporting)

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Inventory, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

dustin@euclid ~ $ invtool SREG create --help
usage: invtool SREG create [-h] [--fqdn FQDN] [--ttl TTL] --ip IP
                           [--no-private | --private] [--no-public | --public]
                           [--description DESCRIPTION] [--comment COMMENT]
                           --system_hostname SYSTEM_HOSTNAME

optional arguments:
  -h, --help            show this help message and exit
  --fqdn FQDN           The FQDN of the record being created. If you use this
                        option you cannot use label or domain
  --ttl TTL             The ttl of a record.
  --ip IP               A string representation of an IP address.
  --no-private          Disable private view.
  --private             Enabled private view.
  --no-public           Disable public view.
  --public              Enabled public view.
  --description DESCRIPTION
                        Tell us a little about this record
  --comment COMMENT     Use this to record why a change is being made
  --system_hostname SYSTEM_HOSTNAME
                        The hostname of the system this registration is
                        associated with
dustin@euclid ~ $ invtool SREG create --system-hostname buildbot-master103.srv.releng.scl3.mozilla.com --ip 10.26.48.60 --private --no-public
usage: invtool SREG create [-h] [--fqdn FQDN] [--ttl TTL] --ip IP
                           [--no-private | --private] [--no-public | --public]
                           [--description DESCRIPTION] [--comment COMMENT]
                           --system_hostname SYSTEM_HOSTNAME
invtool SREG create: error: argument --system_hostname is required
dustin@euclid ~ $ invtool SREG create --system_hostname buildbot-master103.srv.releng.scl3.mozilla.com --ip 10.26.48.60 --private --no-public
Please enter password for encrypted keyring:
Error: fqdn  C, o, u, l, d, n, ', t,  , d, e, t, e, r, m, i, n, e,  , a,  , l, a, b, e, l,  , a, n, d,  , d, o, m, a, i, n,  , f, o, r,  , t, h, i, s,  , r, e, c, o, r, d, .
dustin@euclid ~ $ invtool SREG create --system_hostname buildbot-master103.srv.releng.scl3.mozilla.com --domain srv.releng.scl3.mozilla.com --ip 10.26.48.60 --private --no-public
usage: invtool [-h] [--json | --silent | --debug | --pk-only]

               {A,AAAA,CNAME,MX,PTR,SRV,TXT,search,status,NET,SITE,VLAN,NET_kv,SITE_kv,VLAN_kv,SYS,SYS_kv,csv,ba_export,ba_import,SREG,HW,decommission}
               ...
invtool: error: unrecognized arguments: --domain srv.releng.scl3.mozilla.com

Comment 1

[Jacques Uber [:uberj]]

I pushed some code that addresses this bug. https://github.com/uberj/inv-tool/commit/d463a173d675d2a0b2c744576cfa3a563dedfb10

Mind trying it out?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Oh, cool - that looks good for fixes about --system_hostname and printing the error message as a list, but the last bit is still a problem -- it can't figure out the domain/label, and doesn't seem to have a --domain or --label argument.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

12:31 < uberj> dustin: it can't find the label and domain because invtool was originally not requiring you to pass the --fqdn argument

Yep, you're right - this fixes it.