Closed Bug 972457 Opened 10 years ago Closed 6 years ago

[Contacts API] The substring matching algorithm is likely buggy

Categories

(Core Graveyard :: DOM: Contacts, defect, P5)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: julienw, Unassigned)

Details

In makeImport [1] we end up using substring matching only as a last resort, when PhoneNumberUtils can't parse the number.

However, in _findWithIndex [2] we always use substring matching if it's enabled.

So it's not consistent.

I think it's working (since August!) in all countries because the "nationalMatchingFormat" property returned by PhoneNumberUtils is actually the same than what the substring matching algorithm is doing. It would not work as soon as we badly configure the substring matching property, or if the PhoneNumberUtils lib can't parse a number for a specific country.

Therefore, I think we should just remove the whole substring matching mechanism and solely rely on the nationalMatchingFormat property, which we actually do for 6 months without a complain.

[1] https://mxr.mozilla.org/mozilla-central/source/dom/contacts/fallback/ContactDB.jsm#834
[2] https://mxr.mozilla.org/mozilla-central/source/dom/contacts/fallback/ContactDB.jsm#1251
Summary: The substring matching algorithm is likely buggy → [Contacts API] The substring matching algorithm is likely buggy
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
DOM: Contacts isn't used anymore. 
Closing all remaining bugs.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.