Closed
Bug 972475
Opened 11 years ago
Closed 11 years ago
[System] Killed active ActivityWindow break if 2 "_closed" are triggered at almost the same time
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cedric, Assigned: cedric)
References
Details
Attachments
(1 file)
In the kill method of apps/system/js/activity_window.js:
The '_closed' event listener of the child element is not removed when this event is triggered (it is instead... added again, obviously copy/paste here). It then results in an error and possibly undefined behavior.
Link to code: https://github.com/mozilla-b2g/gaia/blob/f0a1e556fe9f6416c4f96bdf43fc63bcbb55acfc/apps/system/js/activity_window.js#L214
I am not sure it happens in reality, but this is good to fix before it spawns lurking bug.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8375660 -
Flags: review?(alive)
|
|
Assignee | |
Updated•11 years ago
|
Blocks: app-window-manager
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8375660 [details] [review]
Proposed PR, one-line change
Nice catch, thank you!!
Attachment #8375660 -
Flags: review?(alive) → review+
|
|
||
Updated•11 years ago
|
Assignee: nobody → cedric
|
|
||
Updated•11 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Comment 3•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/729e4cef7ad41cd6315430270a31fd5d7513c041
Next time add 'checkin-needed' after r+ someone will merge for you.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•