Rename BaseTest.mLauncherActivityClass to sLauncherActivityClass




Firefox for Android
4 years ago
4 years ago


(Reporter: mcomella, Assigned: Madushan Nishantha, Mentored)


Firefox Tracking Flags

(Not tracked)


(Whiteboard: [lang=java][good first bug])


(1 attachment)

It is a static variable, not an instance variable, so it should start with a lower-case s.
It should also be declared `final`.

Comment 2

4 years ago
I'll take this one :) Just have to rename all the instances on place right?
Indeed! I've assigned the bug to you.

Have you already set up a build environment? If not, you can see the instructions here:

You'll be modifying code in our Robocop test framework, so you'll need to set that up to test that your changes work:

When you make changes in the mobile/android/base/tests/ directory, you should only need to recompile Robocop, not the entire browser, for these changes.

While you're developing, I recommend running just a single test because the full robocop test suite takes a long time to run (at least 30 minutes).

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see

Thanks and happy coding! ^_^
Assignee: nobody → j.l.madushan
(In reply to Michael Comella (:mcomella) from comment #3)
> While you're developing, I recommend running just a single test

And make sure it extends BaseTest! :)

Comment 5

4 years ago
(In reply to Michael Comella (:mcomella) from comment #3)

Thanks, I already have a fennec build environment since I've fixed a bug earlier :) 
How can I run a only single test? I haven't had experiences with Robocop before.

Comment 6

4 years ago
Created attachment 8380571 [details] [diff] [review]

I've changed all the "mLauncherActivityClass" to "sLauncherActivityClass". can someone tell me how to properly test the results. WHen I run make -C {objdir}/build/mobile/robocop/ it builds without problems and installs properly.
To run robocop, you specify:

make -C <objdir> mochitest-robocop

To run a single test, you need to set the TEST_PATH environment variable to the name of the test you want to run, e.g.

TEST_PATH=testBookmark make -C <objdir> mochitest-robocop

You can find the list of tests as any file that starts with "test" in mobile/android/base/tests/; make sure the test you run is a sub-class of BaseTest.
Comment on attachment 8380571 [details] [diff] [review]

Review of attachment 8380571 [details] [diff] [review]:

This looks good to me. Have you tested the results yet?
Attachment #8380571 - Flags: feedback+
Flags: needinfo?(j.l.madushan)

Comment 9

4 years ago
Sorry for the hold up with the test. I'm stuck in some studies these days. I'll Test it and post the result as soon as I get a free time.
Flags: needinfo?(j.l.madushan)
Closing as `BaseTest.mLauncherActivityClass` was previously removed (bug # unknown).
Last Resolved: 4 years ago
Resolution: --- → INVALID


4 years ago
Whiteboard: [mentor=mcomella][lang=java][good first bug] → [lang=java][good first bug]
You need to log in before you can comment on or make changes to this bug.