Closed Bug 972557 Opened 10 years ago Closed 10 years ago

To address Bug 971747 - Add an exception that will report when b2g cannot be stopped

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bsilverberg, Assigned: bsilverberg)

References

Details

Attachments

(1 file, 1 obsolete file)

This checks to see if b2g has been stopped before attempting to start it, and if it has not stopped does a reboot instead.

See bug 971747 for details
Attachment #8375776 - Flags: review?(zcampbell)
Attachment #8375776 - Flags: review?(viorela.ioia)
Attachment #8375776 - Flags: review?(robert.chira)
Attachment #8375776 - Flags: review?(florin.strugariu)
Attachment #8375776 - Flags: review?(dhylands)
Attachment #8375776 - Flags: review?(andrei.hutusoru)
Comment on attachment 8375776 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16265

This looks reasonable to me. However I should point out that any "stop b2g" could hang. Like the stop b2g from the flash.sh script, or from anyplace else, and to be correct we really need to fix all of them.
Attachment #8375776 - Flags: review?(dhylands) → review+
Keywords: qablocker
Keywords: qablocker
Comment on attachment 8375776 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16265

reboot is in stop which is counter-intuitive.
if we put it just in the setUp then it can reboot or start which both share the same intention.
Attachment #8375776 - Flags: review?(zcampbell) → review-
Attachment #8375776 - Flags: review?(florin.strugariu) → review-
This isn't a blocker anymore but it might be a low risk protection against this issue hitting us again in the future and if we play it wisely it won't cost any time.

Let's respin it as a combination of my commit and Dave's idea of waiting for the process to have fully stopped.

Can you take that Bob?
Sure Zac, I'll add that to my queue.
Attachment #8375776 - Attachment is obsolete: true
Attachment #8375776 - Flags: review?(viorela.ioia)
Attachment #8375776 - Flags: review?(robert.chira)
Attachment #8375776 - Flags: review?(andrei.hutusoru)
Summary: Fix for Bug 971747 - Phone freezes while starting and stopping the b2g process → To address Bug 971747 - Add an exception that will report when b2g cannot be stopped
This patch now simply throws an exception if b2g cannot be stopped, so we can be alerted to this if it happens again. None of the solutions we discussed for the issue in IRC were very pretty, so we are going to wait and see if it comes back.
Comment on attachment 8379840 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16523

Looks good, just one nit to address. Leaving open for Zac's feedback.
Attachment #8379840 - Flags: review?(dave.hunt) → review+
Comment on attachment 8379840 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16523

LGTM too aside from Dave's nit.
Attachment #8379840 - Flags: review?(zcampbell) → review+
Blocks: 801898
Severity: normal → critical
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Bob, even though we're not seeing this I'd like to merge this as a good practice/enhancement. Can you address Dave's nit and rebase? Cheers
Flags: needinfo?(bob.silverberg)
This claims to be waiting on a nit fix, but I'm not sure what that is. See https://github.com/mozilla-b2g/gaia/pull/16523#issuecomment-38329991 for discussion.
Flags: needinfo?(bob.silverberg) → needinfo?(dave.hunt)
I'm not sure. I had a nit about the timeout being duplicated in the message, but that was addressed promptly. I believe a rebase will also make this patch smaller as the time unit change has been made separately.
Flags: needinfo?(dave.hunt)
Pardon our tardiness on this one bob. 
I just re-tested this and it's still working fine. Can you squish and we'll merge, as a protection.
Flags: needinfo?(bob.silverberg)
Ok, zac, I squashed the commits and rebased to master.
Flags: needinfo?(bob.silverberg) → needinfo?(zcampbell)
Merged:
https://github.com/mozilla-b2g/gaia/commit/8419ede1baf38f4f659ad24a0dd500209d0f8d2e
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(zcampbell)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: