Closed Bug 972704 Opened 6 years ago Closed 6 years ago

Update to latest verstion of test-agent

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
No description provided.
We land commit of bug 934952 for test-agent that need to update version to 0.17.0.
Summary: Version bump for test-agent → Fetch latest for test-agent
Summary: Fetch latest for test-agent → Update to latest verstion of test-agent
Attached file Gaia PR
Attachment #8376011 - Flags: review?(yurenju.mozilla)
Can we change the test-agent version number to '*' in package.json so that auto track the latest package?
Flags: needinfo?(jlal)
Flags: needinfo?(felash)
Merged.

https://github.com/mozilla-b2g/gaia/commit/8747936fe002b8f34debd9f859b7a53c93683632
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8376011 [details] [review]
Gaia PR

forgot to r+ :P
Attachment #8376011 - Flags: review?(yurenju.mozilla) → review+
If I'm not wrong, "*" means that any installed version works, and that means it won't attempt to fetch the last one if there is already one. What you want is probably "latest" instead? I'd say it's probably fine to use "latest" in this package.json since we only ever update it manually.

I don't want "latest" in any package.json that is automatically updated with a make command that developers usually use though.
Flags: needinfo?(felash)
Just remembered that:
* "make test-agent-server" is actually doing a "npm install"
* we still need to run "make update-common" by hand

So I'd rather not use "latest" and update the version by hand.

That said, I think we could try to change the system to run "update-common" automatically instead of doing it by hand.
A similar things I have done before https://bugzilla.mozilla.org/show_bug.cgi?id=963450

In is this patch I put "update-common" into general "make".
Flags: needinfo?(jlal)
To be clear, what I try to avoid is running "npm install" in situations where we don't have the network (eg: in a train, flight, subway, countryside).
You need to log in before you can comment on or make changes to this bug.