972704 - Update to latest verstion of test-agent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Comment 1

[Ricky Chien [:rickychien] (inactive)]

We land commit of bug 934952 for test-agent that need to update version to 0.17.0.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Can we change the test-agent version number to '*' in package.json so that auto track the latest package?

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged.

https://github.com/mozilla-b2g/gaia/commit/8747936fe002b8f34debd9f859b7a53c93683632

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8376011 [details] [review]
Gaia PR

forgot to r+ :P

Comment 6

[Julien Wajsberg [:julienw]]

If I'm not wrong, "*" means that any installed version works, and that means it won't attempt to fetch the last one if there is already one. What you want is probably "latest" instead? I'd say it's probably fine to use "latest" in this package.json since we only ever update it manually.

I don't want "latest" in any package.json that is automatically updated with a make command that developers usually use though.

Comment 7

[Julien Wajsberg [:julienw]]

Just remembered that:
* "make test-agent-server" is actually doing a "npm install"
* we still need to run "make update-common" by hand

So I'd rather not use "latest" and update the version by hand.

That said, I think we could try to change the system to run "update-common" automatically instead of doing it by hand.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

A similar things I have done before https://bugzilla.mozilla.org/show_bug.cgi?id=963450

In is this patch I put "update-common" into general "make".

Comment 9

[Julien Wajsberg [:julienw]]

To be clear, what I try to avoid is running "npm install" in situations where we don't have the network (eg: in a train, flight, subway, countryside).