972804 - [Camera] Separate settings for camera and video flash

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Wilson Page [:wilsonpage]]

Currently we has a single 'flashModes' setting. This is problematic to share between picture and video modes as they have differing requirements.

Picture: 'auto', 'on', 'off'
Video: 'off', 'torch'

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: Pull Reques

Comment 2

[Wilson Page [:wilsonpage]]

The above PR need to be rebased on top of the settings branch once it has FINALLY landed in master. But the code can still be r+'ed.

Comment 3

[Diego Marcos [:dmarcos]]

Can you squash and push again?

Comment 4

[Wilson Page [:wilsonpage]]

Cool done :)

Comment 5

[Diego Marcos [:dmarcos]]

You are a peer now. You can go ahead and land your patch.

Comment 6

[Wilson Page [:wilsonpage]]

I don't see the 'Merge' button on GitHub. Guessing I'm still not authorised to land patches on master.

Comment 7

[Wilson Page [:wilsonpage]]

This needs to land in master as bugs could be flagged if it isn't. Other settings work can land in the camera-new-features branch.

Comment 8

[David Flanagan [:djf]]

Per comment 7, merging this to master to stabilize features already landed there.

https://github.com/mozilla-b2g/gaia/commit/709d8572b5ef607b1b16c78ebe6c12a6bb3af258