Re-enable dom/apps tests on B2G when they run reliably

RESOLVED FIXED in Firefox 30

Status

defect
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: RyanVM, Assigned: marco)

Tracking

(Blocks 1 bug)

unspecified
mozilla31
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox29 unaffected, firefox30 fixed, firefox31 fixed, firefox-esr24 unaffected, b2g-v1.3 unaffected, b2g-v1.4 fixed, b2g-v2.0 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

5 years ago
Unfortunately, the dom/apps tests are more intermittently green than orange these days (as in, nearly perma-fail). In the past, it seems that disabling our way to victory in these tests has been a game of whack-a-mole, so I am disabling the entire directory until their problems are resolved and they can be re-enabled.
Assignee: nobody → ferjmoreno
Reporter

Comment 4

5 years ago
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #3)
> https://tbpl.mozilla.org/?tree=Try&rev=52e31b68ae09

This was on top of a parent changeset that doesn't include the fix from bug 903291. Here's a new Try run on top of m-c tip.
https://tbpl.mozilla.org/?tree=Try&rev=6c2a31983b0c
Reporter

Comment 5

5 years ago
Still seeing opt and debug dom/apps failures in the Try run.
I am afraid that I have no time to look at this this week.
Assignee: ferjmoreno → nobody
Assignee

Comment 7

5 years ago
Posted patch Patch (obsolete) — Splinter Review
Attachment #8397871 - Flags: review?(ryanvm)
Reporter

Comment 8

5 years ago
Try link?
Assignee

Comment 9

5 years ago
With bug 981085 fixed, I think we can re-enable these tests.

Try run is green: https://tbpl.mozilla.org/?tree=Try&rev=1c65d75fb4a4
Reporter

Comment 10

5 years ago
Comment on attachment 8397871 [details] [diff] [review]
Patch

Wow that's a lot of green! (And yes, I'm sure I retriggered the right chunks :P)

However, you still have nearly all of the tests disabled on debug individually. Is that your intention? I'll sign off on this if you want, I'm just not sure you're accomplishing all that you intend to here. And I'd obviously want to see a Try run with all those tests re-enabled as well before signing off on that.

[test_app_update.html]
skip-if = (toolkit == 'gonk' && debug) #debug-only failure
[test_bug_795164.html]
[test_packaged_app_common.js]
[test_packaged_app_install.html]
skip-if = (toolkit == 'gonk' && debug) #debug-only failure
[test_packaged_app_update.html]
skip-if = toolkit=='gonk' # b2g(bug 915879) b2g-debug(debug-only timeout)
[test_uninstall_errors.html]
skip-if = (toolkit == 'gonk' && debug) #debug-only timeout
[test_receipt_operations.html]
[test_install_receipts.html]
Attachment #8397871 - Flags: review?(ryanvm) → review+
Assignee

Comment 11

5 years ago
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> However, you still have nearly all of the tests disabled on debug
> individually. Is that your intention? I'll sign off on this if you want, I'm
> just not sure you're accomplishing all that you intend to here. And I'd
> obviously want to see a Try run with all those tests re-enabled as well
> before signing off on that.

I thought the individual disabled tests were unrelated failures, but, yes, you're right, it is possible bug 981085 fixed those as well.
I'll spin another try run with all the tests enabled.
Reporter

Comment 13

5 years ago
Can you please not run *all* builds/tests for a b2g-specific mochitest re-enabling? That's a colossal waste of Try resources.
Assignee

Comment 14

5 years ago
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #13)
> Can you please not run *all* builds/tests for a b2g-specific mochitest
> re-enabling? That's a colossal waste of Try resources.

Sure, I usually try to avoid wasting try resources as much as possible, this time I haven't been meticulous enough.
Reporter

Updated

5 years ago
Attachment #8398136 - Flags: review?(ryanvm) → review+
Assignee

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: [tests disabled on B2G][leave open] → [tests disabled on B2G]
Reporter

Comment 15

5 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/100574f8dbd8
Assignee: nobody → mar.castelluccio
Keywords: checkin-needed
Whiteboard: [tests disabled on B2G]
https://hg.mozilla.org/mozilla-central/rev/100574f8dbd8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Depends on: 1010321

Updated

2 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.