972927 - Re-enable dom/apps tests on B2G when they run reliably

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Unfortunately, the dom/apps tests are more intermittently green than orange these days (as in, nearly perma-fail). In the past, it seems that disabling our way to victory in these tests has been a game of whack-a-mole, so I am disabling the entire directory until their problems are resolved and they can be re-enabled.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2dc2fbd07412

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2dc2fbd07412

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

https://tbpl.mozilla.org/?tree=Try&rev=52e31b68ae09

Comment 4

[Ryan VanderMeulen [:RyanVM]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #3)
> https://tbpl.mozilla.org/?tree=Try&rev=52e31b68ae09

This was on top of a parent changeset that doesn't include the fix from bug 903291. Here's a new Try run on top of m-c tip.
https://tbpl.mozilla.org/?tree=Try&rev=6c2a31983b0c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Still seeing opt and debug dom/apps failures in the Try run.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

I am afraid that I have no time to look at this this week.

Comment 7

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Try link?

Comment 9

[Marco Castelluccio [:marco]]

With bug 981085 fixed, I think we can re-enable these tests.

Try run is green: https://tbpl.mozilla.org/?tree=Try&rev=1c65d75fb4a4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8397871 [details] [diff] [review]
Patch

Wow that's a lot of green! (And yes, I'm sure I retriggered the right chunks :P)

However, you still have nearly all of the tests disabled on debug individually. Is that your intention? I'll sign off on this if you want, I'm just not sure you're accomplishing all that you intend to here. And I'd obviously want to see a Try run with all those tests re-enabled as well before signing off on that.

[test_app_update.html]
skip-if = (toolkit == 'gonk' && debug) #debug-only failure
[test_bug_795164.html]
[test_packaged_app_common.js]
[test_packaged_app_install.html]
skip-if = (toolkit == 'gonk' && debug) #debug-only failure
[test_packaged_app_update.html]
skip-if = toolkit=='gonk' # b2g(bug 915879) b2g-debug(debug-only timeout)
[test_uninstall_errors.html]
skip-if = (toolkit == 'gonk' && debug) #debug-only timeout
[test_receipt_operations.html]
[test_install_receipts.html]

Comment 11

[Marco Castelluccio [:marco]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> However, you still have nearly all of the tests disabled on debug
> individually. Is that your intention? I'll sign off on this if you want, I'm
> just not sure you're accomplishing all that you intend to here. And I'd
> obviously want to see a Try run with all those tests re-enabled as well
> before signing off on that.

I thought the individual disabled tests were unrelated failures, but, yes, you're right, it is possible bug 981085 fixed those as well.
I'll spin another try run with all the tests enabled.

Comment 12

[Marco Castelluccio [:marco]]

Attachment: Patch

https://tbpl.mozilla.org/?tree=Try&rev=6a79711603ec
https://tbpl.mozilla.org/?tree=Try&rev=af8311ee670a

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Can you please not run *all* builds/tests for a b2g-specific mochitest re-enabling? That's a colossal waste of Try resources.

Comment 14

[Marco Castelluccio [:marco]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #13)
> Can you please not run *all* builds/tests for a b2g-specific mochitest
> re-enabling? That's a colossal waste of Try resources.

Sure, I usually try to avoid wasting try resources as much as possible, this time I haven't been meticulous enough.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/100574f8dbd8

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/100574f8dbd8

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9c41e6f07c3e

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/9c41e6f07c3e