Closed Bug 972940 Opened 6 years ago Closed 6 years ago

Rename the CC env vars from XPCOM_CC to MOZ_CC

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: mccr8, Assigned: mccr8)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

No description provided.
Does that sounds okay to you, Olli?
Flags: needinfo?(bugs)
Hmm, why?
Flags: needinfo?(bugs)
There's no particular reason why a given var is XPCOM_CC_ or MOZ_CC_, as far as I can see.  It would be nice to be consistent, so you don't have to remember.
This makes the names consistent. I need to make sure MDN doesn't list the old names.

https://tbpl.mozilla.org/?tree=Try&rev=af50cdecffa3
Attachment #8376897 - Flags: review?(bugs)
Comment on attachment 8376897 [details] [diff] [review]
Rename XPCOM_CC_ env vars to MOZ_CC_.

Please update https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump
Attachment #8376897 - Flags: review?(bugs) → review+
Keywords: dev-doc-needed
Trivial patch.

I'm pretty sure my giant push yesterday leaked in Valgrind because I failed to update its usage of this environment variable, so we failed to run shutdown CCs.

https://tbpl.mozilla.org/?tree=Try&rev=03b529b1c392
Attachment #8379088 - Flags: review?(gps)
Comment on attachment 8379088 [details] [diff] [review]
part 2 - Update the Valgrind mach command to use the new environment variable name.

green Valgrind try run: https://tbpl.mozilla.org/?tree=Try&rev=03b529b1c392

Maybe Nick can get to this review first.  It is a super trivial patch, so it only really needs a rubber stamp.
Attachment #8379088 - Flags: review?(n.nethercote)
Comment on attachment 8379088 [details] [diff] [review]
part 2 - Update the Valgrind mach command to use the new environment variable name.

Review of attachment 8379088 [details] [diff] [review]:
-----------------------------------------------------------------

I think one r+ is enough for this patch :)
Attachment #8379088 - Flags: review?(n.nethercote)
Attachment #8379088 - Flags: review?(gps)
Attachment #8379088 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/8991d3139e40
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.