972940 - Rename the CC env vars from XPCOM_CC to MOZ_CC

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Does that sounds okay to you, Olli?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Hmm, why?

Comment 3

[Andrew McCreight [:mccr8]]

There's no particular reason why a given var is XPCOM_CC_ or MOZ_CC_, as far as I can see.  It would be nice to be consistent, so you don't have to remember.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Rename XPCOM_CC_ env vars to MOZ_CC_.

This makes the names consistent. I need to make sure MDN doesn't list the old names.

https://tbpl.mozilla.org/?tree=Try&rev=af50cdecffa3

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8376897 [details] [diff] [review]
Rename XPCOM_CC_ env vars to MOZ_CC_.

Please update https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump

Comment 6

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53fcde23863a

Comment 7

[Andrew McCreight [:mccr8]]

Updated the documentation: https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump

Comment 8

[Andrew McCreight [:mccr8]]

valgrind leaks
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7f83da8e0fe

Comment 9

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Update the Valgrind mach command to use the new environment variable name.

Trivial patch.

I'm pretty sure my giant push yesterday leaked in Valgrind because I failed to update its usage of this environment variable, so we failed to run shutdown CCs.

https://tbpl.mozilla.org/?tree=Try&rev=03b529b1c392

Comment 10

[Andrew McCreight [:mccr8]]

Comment on attachment 8379088 [details] [diff] [review]
part 2 - Update the Valgrind mach command to use the new environment variable name.

green Valgrind try run: https://tbpl.mozilla.org/?tree=Try&rev=03b529b1c392

Maybe Nick can get to this review first.  It is a super trivial patch, so it only really needs a rubber stamp.

Comment 11

[Nicholas Nethercote [inactive]]

Comment on attachment 8379088 [details] [diff] [review]
part 2 - Update the Valgrind mach command to use the new environment variable name.

Review of attachment 8379088 [details] [diff] [review]:
-----------------------------------------------------------------

I think one r+ is enough for this patch :)

Comment 12

[Andrew McCreight [:mccr8]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/8991d3139e40

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8991d3139e40