Closed Bug 973026 Opened 10 years ago Closed 9 years ago

[B2G][Camera] No warning message pops up on the Buri about low storage when taking a video

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.2 affected, b2g-v1.3 affected, b2g-v1.4 affected, b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 unaffected, b2g-master unaffected)

RESOLVED WORKSFORME
Tracking Status
b2g-v1.2 --- affected
b2g-v1.3 --- affected
b2g-v1.4 --- affected
b2g-v2.0 --- affected
b2g-v2.1 --- affected
b2g-v2.2 --- unaffected
b2g-master --- unaffected

People

(Reporter: croesch, Unassigned)

References

Details

(Whiteboard: permafail interaction-design, ux-most-wanted-nov2014, 2x-uxnom)

Attachments

(4 files)

Attached file log.txt
Description:
  On the Buri device, when a user is on low storage space such as 16 megs of storage space, if the user tries to take a video to fill up the remaining space, the user does not get a low storage space warning. The only message a user will see is when there is no more storage space left and the recording will not get saved.

Repro Steps:
1) Update Buri to Build ID: 20140214004001
2) Have a memory card that is completely full
3) Delete a few photos or a video to clear up about 16-20 megs.
4) Start taking a video and let it eat up the remaining storage space.
5) Notice that before the user gets the Out of Storage, there is no warning for low storage.

Actual:
 Missing a low storage warning message when recording a video.

Expected:
 User should be warned of running out of storage space when recording a video.

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL)
Build ID: 20140214004001
Gecko: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/e3766683210c
Gaia: 22e065f75193f569a78a8ec827b08e1ed520e1b2
Platform Version: 28.0
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 100%
Test Suite Name: (Camera)
UCID: (camera-032)
Link to failed test case: https://moztrap.mozilla.org/runtests/run/3342/env/347/?&pagenumber=1&pagesize=100&sortfield=order&sortdirection=asc&filter-id=3326&filter-suite=125
See attached: Log file
Also occurs on V1.2 with the following variables:

Environmental Variables
Device: Buri 1.2 Mozilla
Build ID: 20140210004002
Gecko: https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/2673f348598c
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0
Firmware Version: v1.2-device.cfg
Whiteboard: burirun1.3-3 → burirun1.3-3, burirun1.4-1
Whiteboard: burirun1.3-3, burirun1.4-1 → permafail
Also repros on flame 2.0

2.0 Environmental Variables:
Device: Flame 2.0 MOZ
BuildID: 20140527040202
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: cbe4f69c2e9c
Version: 32.0a1
Firmware Version: v10g-2
When the device runs out of space we stop recording, save the video and display a message (attached image). No data is lost but it might be useful to show a message / icon on screen indicating that the phone is about to run out of space so we give the opportunity to the user to properly stop the video.
Flags: needinfo?(tshakespeare)
Sorry guys - this is going to have to wait. Focusing on 2.0+ items and getting ready for media work week.
The same would be true for photos as well I'm guessing. I agree with Diego that we should be showing a message more preemptively than after the fact.

I'm going to assume that I won't be able to tackle this before I go out on leave so I'm going to NI Katie to take a look and come up with some guidelines for this error message.
Flags: needinfo?(tshakespeare) → needinfo?(kcaldwell)
Whiteboard: permafail → permafail interaction-design
Hi Gregor...

Is there an engineer in the systems fe team that would be able to give Katie and the media team some direction on the implementation of low storage warnings? Or is that a separate team?

- Rob
Flags: needinfo?(anygregor)
(In reply to Rob MacDonald [:robmac] from comment #7)
> Hi Gregor...
> 
> Is there an engineer in the systems fe team that would be able to give Katie
> and the media team some direction on the implementation of low storage
> warnings? Or is that a separate team?
> 
> - Rob

Trying to understand what help you are looking for. Is the question what events we can provide to the system app so we can take action? We should be pretty flexible and get you what you need in order to provide a good UX. The system app can listen to low storage events and take proper action.
It's more complicated if every app wants to implement their own action based on low memory events. Like stop recording when we are on low memory. But we already show memory information in the settings app so the information must already be available. I believe Dave is the right person in the Media team that can help with low storage questions.
Flags: needinfo?(anygregor)
Thanks, Gregor... I was wondering what the current system warnings are so that individual apps, including media, don't display redundant messages. Would that still be Dave? - Rob
Flags: needinfo?(anygregor)
(In reply to Rob MacDonald [:robmac] from comment #9)
> Thanks, Gregor... I was wondering what the current system warnings are so
> that individual apps, including media, don't display redundant messages.
> Would that still be Dave? - Rob

That's probably not Dave. It should be a gaia dev but I am not sure we have anyone that knows all the warnings we display based on low disk space. Mike can help out here. Maybe Tim can add someone else from his team that worked on it before.
Flags: needinfo?(timdream)
Flags: needinfo?(mhenretty)
Flags: needinfo?(anygregor)
(In reply to Gregor Wagner [:gwagner] from comment #10)
> (In reply to Rob MacDonald [:robmac] from comment #9)
> > Thanks, Gregor... I was wondering what the current system warnings are so
> > that individual apps, including media, don't display redundant messages.
> > Would that still be Dave? - Rob
> 
> That's probably not Dave. It should be a gaia dev but I am not sure we have
> anyone that knows all the warnings we display based on low disk space. Mike
> can help out here. Maybe Tim can add someone else from his team that worked
> on it before.

Redirecting to Aus since I remember he did some gecko event work for when the sdcard ran out of space during downloads.

Aus, do you know what warnings we get in the system when we run low on disk space? If you don'w know off the top of your head, feel free to redirect back to me.
Flags: needinfo?(aus)
Flags: needinfo?(mhenretty)
As of yet, there is no global system app level monitoring of disk space available. Therefor, the checks we do in the system app are related only to downloads failing because of disk space issues (or that there is not enough disk space prior to download since we check for this).

There would be no redundancy in the camera app doing it's own disk space check when the user is about to start a recording. As for during recording, there's no API to be notified of disk free space changes. The camera app would have to determine the amount of freespace available when starting to record and estimate how long it can record before hitting the limit. The DeviceStorage API provides a way to get the amount of freespace from a particular piece of Storage.
Flags: needinfo?(aus)
I don't remember there is anyone in my team have worked on this but I remember low memory issues are constant cert blockers from partners. Evelyn, does this bug ring any bell to you?
Flags: needinfo?(timdream) → needinfo?(ehung)
I don't remember too much either, but I know we have a |storage_watcher| for guarding app storage (see bug 1042603 comment 5) in System app. For camera, we also check free media storage space before taking pictures and recording, and show a warning when running out of space as comment 3 said.
Flags: needinfo?(ehung)
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(dharris)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(dharris)
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Diego, when you get a minute can you please review this attachment. Contains mini UX spec for related bugs: Bug 837207 and Bug 973026.
Flags: needinfo?(kcaldwell) → needinfo?(dmarcos)
Blocks: 1098152
Blocks: 994991
Whiteboard: permafail interaction-design → permafail interaction-design, ux-most-wanted-nov2014
Whiteboard: permafail interaction-design, ux-most-wanted-nov2014 → permafail interaction-design, ux-most-wanted-nov2014, 2x-uxnom
qawanted to check whether this issue still repros in flame.  If so, hema should be ni?ed.
Keywords: qawanted
This issue does not reproduce on Flame 3.0 and 2.2. Following STR, an error message appears as soon as Camera stops recording. See attached photo for the message. (I couldn't take a screenshot since my memory was full)

Device: Flame 3.0 (full flashed 319MB KK)
BuildID: 20150429010205
Gaia: 6e35b0948c42a4398b8a5916015de167121683a1
Gecko: 1ad65cbeb2f4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2 (full flashed 319MB KK)
BuildID: 20150429002501
Gaia: 1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gecko: d38ff4717f39
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage+][lead-review+] → [QAnalyst-Triage?][lead-review+]
Flags: needinfo?(ktucker)
Keywords: qawanted
QA Whiteboard: [QAnalyst-Triage?][lead-review+] → [QAnalyst-Triage+][lead-review+]
Flags: needinfo?(ktucker)
Hema, I suppose that we can close this issue if it is not reproducible in flame?
Flags: needinfo?(hkoka)
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(hkoka)
Flags: needinfo?(dmarcos)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: