Closed Bug 973050 Opened 8 years ago Closed 4 years ago

Add back the borders on the keyboard keys

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: vingtetun, Unassigned)

References

Details

Bug 969544 removes some of the geometry changes when a key is highlighted in order to save some small reflows and a small extra repaint area.

This bug is a followup to add back the same look and feel but in a way that does not create extra reflows, or extra repaints.
I have an idea as to how to fix this but I don't have time to try it yet.

We can add a :before element to each key which inherits the dimensions of the key itself and is absolutely positioned on top of it. If we set the opacity to 0.5 or something and give it a background color, we can basically tint each key when highlighted without requiring any reflow.

:vingtetun pointed out on IRC that this would require additional memory use since we have k (one per key) new frames, but I don't think it would be a very serious drain and that the perf boost we would get would be easily worth it.
As we say in Dutch 'meten is weten' (measurement is knowledge) :-)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.