973064 - Signon.autologin.proxy doesn't work on first pageload

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect)

Description

[Manish Goregaokar [:manishearth]]

It seems that when signon.autologin.proxy is enabled, on the first page load (Either on the new tab page or if you call Firefox with the URL as a parameter) the proxy prompt still appears.

Canceling the prompt and reloading the page (or opening a new tab) doesn't respawn the prompt though, so it seems like autologin is working in general, just not on the first pageload of the browser session.

Comment 1

[Manish Goregaokar [:manishearth]]

CCing BenB since the original patch was his (bug 521467)

Comment 2

[Ben Bucksch (:BenB)]

That did work when I implemented it.

Comment 3

[Ben Bucksch (:BenB)]

See the initial description of bug 521467 how it's supposed to work.
Note that you need to enter the password once, and set [x] remember it.
My patch merely made Firefox use the password that we already stored.
For a fresh profile, you need to load a page first, enter the password, and check "[x] remember it". Then, you should not ever have to enter it again, even after browser restart.

I tested that and it did work back then.

Comment 4

[Manish Goregaokar [:manishearth]]

Yep, my password is saved, and it is autofilled.

Like I said, the autologin goes through if I cancel the login and open another page (which should show the login again, but it doesn't)

Comment 5

[Ben Bucksch (:BenB)]

Manish, could you investigate this, please?
Maybe it's your testing or test setup that's wrong, or mine, or something regressed in the meantime.

You can do a "binary search" [1] to find the commit that regressed it.
Start with a build right after it got checked in, to verify that it really did work back then, with your test setup.

Or you could try looking in the code, but it'll be hairy.

[1] http://www.rumblingedge.com/2009/02/24/howto-find-regression-windows-through-manual-binary-search/

Comment 6

[Manish Goregaokar [:manishearth]]

I don't mind looking into this, but I have exams for the next week, so I can't do any heavier contributions.


I'll try to verify that the bug is with the code and not my system, however.

Comment 7

[Manish Goregaokar [:manishearth]]

I downloaded the latest nightly, and the setting seemed to work fine (without touching the profile).

Probably is an issue with my build. I'll mark it as WFM for now, but I'll update this later when I finish pulling and rebuilding Nightly.