973087 - nsSimplePageSequence.* should have "Frame" suffix, to match the name of the class it actually defines

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P4)

Description

[Daniel Holbert [:dholbert]]

Right now, nearly every frame class is defined in its own .h/.cpp file (sometimes just the .cpp file), and as a rule, the file has the same name as the frame class.

One notable exception, however, is nsSimplePageSequenceFrame; it's in nsSimplePageSequence.h/.cpp (no "Frame" in the filename). 

This is inconsistent and unnecessary. We should add "Frame" to make it consistent (and to make it clear that this file defines a frame class).

(noticed while chatting with :Six about bug 919806)

Comment 1

[Mats Palmgren (inactive)]

nsSimplePageSequenceFrame is such a silly name, can we rename it as well?
At least drop the "Simple".

Comment 2

[Daniel Holbert [:dholbert]]

That'd be a substantially larger patch; it'd involves renaming all usages of the class name, and could potentially need some reindentation, etc.

I believe :six already has a patch prepared to do *just* the file-rename, making the filename consistent with the (existing) class-name. I think that's worth taking on its own, as one atomic change.

From there, we can do further renaming (of the newly-consistently-named file & class simultaneously), if you like.

Comment 3

[Arnaud Sourioux [:Six]]

Attachment: nsSimplePageSequenceFrame.patch

Build is green: https://tbpl.mozilla.org/?tree=Try&rev=edcc93791f20
moves nsSimplePageSequence[.h|.cpp] to nsSimplePageSequenceFrame[.h|.cpp]
changes all references to nsSimplePageSequence

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3f154feea8

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a3f154feea8