Closed
Bug 973112
Opened 10 years ago
Closed 10 years ago
Move JS error tracking snippet
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Webmaker Graveyard
webmaker.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: admix)
References
Details
(Whiteboard: [mentor=gvn][goodfirstbug])
Attachments
(1 file)
We have a inline script that should be moved to it's own file: https://github.com/mozilla/webmaker.org/blob/6993b1ced480d4758c884632c0600ff0445cd34c/views/layout.html#L23-L30 It might also be good to move away from using "window.onerror = ..." to "window.addEventListener('error', ...)"
|
Assignee | |
Comment 1•10 years ago
|
||
Can you assign me to this one. thanks.
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → admix.snurnikov
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
PR -> https://github.com/mozilla/webmaker.org/pull/608
Attachment #8378554 -
Flags: review?(jon)
|
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8378554 [details]
Moved error tracker to a separate file, change 'onerror' to 'eventListener'
Need to add the `window.jsErrorDetected = true;` bit back
Attachment #8378554 -
Flags: review?(jon) → review-
|
|
Assignee | |
Comment 4•10 years ago
|
||
Added back 'window.jsErrorDetected = true;'. PR https://github.com/mozilla/webmaker.org/pull/608
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8378554 -
Flags: review- → review?(jon)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8378554 -
Flags: review?(jon) → review+
|
||
Comment 5•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/a21606f79b9e31e107dd2147704e1294cdc1fe97 [bug973112] - Moved error tracker to a separate file, change 'onerror' to 'eventListener' [bug973112] - Modified eventListener [bug973112] - Added 'window.jsErrorDetected = true;' back https://github.com/mozilla/webmaker.org/commit/2d01f3ea3511e7d4070ce766ff25efa1f4d5b13a Merge pull request #608 from admix/bug973112 [bug973112] - Moved error tracker to a separate file, change 'onerror' to 'eventListener'
|
|
Reporter | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•