Remove inline script for quick-linking to a tag

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jon, Assigned: admix)

Tracking

Details

(Whiteboard: [mentor=k88hudson][goodfirstbug])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We used to have the functionality to redirect users to a tag search by linking them to https://webmaker.org/#sometag . However, with the new homepage you have to quick-link to the tag by going through https://webmaker.org/gallery#sometag . We should just remove this functionality, since I suspect nobody uses it. Simply delete all of https://github.com/mozilla/webmaker.org/blob/94975e2879329dbd4802e960c514af5ae11be4f9/views/index.html#L26-L34 and make sure the gallery page still loads!
(Assignee)

Comment 1

5 years ago
Can you assign this one as well, please.
(Reporter)

Updated

5 years ago
Assignee: nobody → admix.snurnikov
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 8376659 [details]
Removed inline script. Gallery page works as it suppose to.

PR -> https://github.com/mozilla/webmaker.org/pull/605
Attachment #8376659 - Flags: review?(jon)
(Reporter)

Updated

5 years ago
Attachment #8376659 - Flags: review?(jon) → review+
(Reporter)

Comment 4

5 years ago
Thanks :admix!
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.