973139 - GStreamerReader considers EOS of one stream to be EOS of all streams

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I discovered that mochitest test_streams_element_capture.html was failing on gizmo.mp4 on Linux/GStreamer/Ubuntu 12.04 x64. The failure was the media was finishing playing and reporting EOS before it reached the duration stated in the files metadata.

The problem is that the GStreamerReader is receiving a callback for EOS of an GstAppSink and assuming that the EOS applies to all both the audio and video app sink, not the stream for the app sink for which the callback arrived for. We receive a callback for both the audio and video appsink, and we should track the sink's EOS separately. I think we should also wait until the decoded count of buffers for a stream is 0 before reporting EOS to the state machine.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Track EOS of audio and video app sinks separately

Track EOS of audio and video app sinks separately. This fixes the test for me.

I also initialized the "duration" variable in GStreamerReader::DecodeVideoFrame() to prevent an uninitialized variable used warning.

Comment 2

[Alessandro Decina]

Comment on attachment 8376642 [details] [diff] [review]
Patch: Track EOS of audio and video app sinks separately

Review of attachment 8376642 [details] [diff] [review]:
-----------------------------------------------------------------

Well spotted. Patch looks good!

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4ff618cf72b

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c4ff618cf72b