973144 - Add the UNDEFINES variable to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[(no longer active)]

Attachment: Add the UNDEFINES variable to moz.build

Comment 2

[Mike Hommey [:glandium]]

If there really only that place with -U flags, i'd rather fix the code than add a moz.build variable for that. Because when you look at it, it's completely weird. Why need to undefine platform variables for those very platforms?

Comment 3

[Mike Hommey [:glandium]]

What are those undefines needed for at all?

Comment 4

[(no longer active)]

FWIW I don't know why they are needed.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Support DEFINES[FOO]=False in moz.build for -UFOO

So after checking on irc with jesup and testing on mac, it turns out the sctp code is a mess that *does* require those undefines (not all of them, though). But for so few, I'd rather not add a new specialized moz.build variable.

Considering DEFINES['FOO'] = True means -DFOO (without =something), and considering DEFINES['FOO'] = False currently raises an exception, i think it makes sense to just use DEFINES['FOO'] = False to mean -UFOO.

Note this doesn't cover moving the -U flags from Makefile.in.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb02c9e3db0a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb02c9e3db0a

Comment 8

[(no longer active)]

FWIW this syntax is pretty terrible, and it will confuse anyone who comes across it.  I think this was a mistake.