Closed Bug 973189 Opened 6 years ago Closed 6 years ago

Get rid of the browser.ctrlTab.recentlyUsedLimit pref

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Too much overhead for questionable customizability gain. Some of the overhead was needed anyway since _recentlyUsedTabs wouldn't contain all tabs when restoring a session, but that's not true anymore.

browser_ctrlTab.js still passes.
Attachment #8376702 - Flags: review?(ttaubert)
Comment on attachment 8376702 [details] [diff] [review]
patch

Review of attachment 8376702 [details] [diff] [review]:
-----------------------------------------------------------------

Should we now just limit the number of displayed items to a constant of 7? It looks like this was the default up until now and with this change we would have no limit at all which could look a little weird with 20 tabs?
Attachment #8376702 - Flags: review?(ttaubert) → feedback+
Comment on attachment 8376702 [details] [diff] [review]
patch

(In reply to Tim Taubert [:ttaubert] from comment #1)
> Should we now just limit the number of displayed items to a constant of 7?
> It looks like this was the default up until now and with this change we
> would have no limit at all which could look a little weird with 20 tabs?

Already the case:
http://hg.mozilla.org/mozilla-central/annotate/6e3ec93efe1d/browser/base/content/browser-tabPreviews.js#l247
The maximum number of items displayed is determined by the number of DOM nodes with the ctrlTab-preview class, not by the length of tabList.
Attachment #8376702 - Flags: review?(ttaubert)
Comment on attachment 8376702 [details] [diff] [review]
patch

Review of attachment 8376702 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for clarifying.
Attachment #8376702 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/2d8dd2ea8a24
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Verified with latest build of Nightly
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.