973189 - Get rid of the browser.ctrlTab.recentlyUsedLimit pref

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Too much overhead for questionable customizability gain. Some of the overhead was needed anyway since _recentlyUsedTabs wouldn't contain all tabs when restoring a session, but that's not true anymore.

browser_ctrlTab.js still passes.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8376702 [details] [diff] [review]
patch

Review of attachment 8376702 [details] [diff] [review]:
-----------------------------------------------------------------

Should we now just limit the number of displayed items to a constant of 7? It looks like this was the default up until now and with this change we would have no limit at all which could look a little weird with 20 tabs?

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8376702 [details] [diff] [review]
patch

(In reply to Tim Taubert [:ttaubert] from comment #1)
> Should we now just limit the number of displayed items to a constant of 7?
> It looks like this was the default up until now and with this change we
> would have no limit at all which could look a little weird with 20 tabs?

Already the case:
http://hg.mozilla.org/mozilla-central/annotate/6e3ec93efe1d/browser/base/content/browser-tabPreviews.js#l247
The maximum number of items displayed is determined by the number of DOM nodes with the ctrlTab-preview class, not by the length of tabList.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8376702 [details] [diff] [review]
patch

Review of attachment 8376702 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for clarifying.

Comment 4

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/2d8dd2ea8a24

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2d8dd2ea8a24

Comment 6

[Tracy Walker [:tracy]]

Verified with latest build of Nightly