The filepicker doesn't let you say 'only pick applications' so we end up passing "*" as the filter all over the code which lets you pick _any file_, apps included. This allows the user to do wonderful things like tell mozilla to open a file with the application being some random text file on their disk.
This is tricky... unlike other types of files, there is no standard extension for applications (except on windows). We could just add an applications flag to the possible filters and leave it up to the various filepicker implementations to figure out what to do with it. Windows is pretty easy, unix would require checking for +x permission, not sure about mac.
mac has several mechanisms for determining if something is an app. that's not hard.
This should be easy & worthwhile on all platforms. ->bryner p3/enhancement/096
Assignee: trudelle → bryner
Severity: normal → enhancement
Priority: -- → P3
Target Milestone: --- → mozilla0.9.6
Target Milestone: mozilla0.9.7 → mozilla0.9.9
What we really need is an application picker, similar to what the Finder and Windows Explorer display for unknown document types. Users should not have to pick apps using the file system, a flat list (with icons) is much better.
Hrmm. That would require us to trawl through all the users's mounted drives, hunting for applications. That's hugely expensive on platforms like Mac where there is no registry to help you. (Ever regretted hitting the Change button for a Helper app in the Internet control panel?)
Add an 'ers' onto 'us' and you have my point. On some platforms, doing the right thing may be prohibitively expensive, and we may have to be expedient. That doesn't mean we have to make all users do the work everywhere.
Nominating for nsbeta1 triage.
Created attachment 69436 [details] [diff] [review] patch This implements "Applications" as a filter type on Unix and Windows (the Mac filepicker implementation doesn't support filtering of any kind at present). I used a special file extension, "..apps", which the user never sees but which the filepicker should recognize and transform into the appropriate filtering mechanism for that platform.
pink, do you think you could make the necessary changes on mac?
dagley should do it, i think he has time the mac does do filtering, it's just all internal. the user can't affect it.
Isn't there a way we can display the application picker that Windows displays when you open an unknown file type?
I imagine we could, but that shouldn't be part of the nsIFilePicker interface. I'd imagine a new nsIAppPicker service that's implemented where available, and then fall back to creating a file picker with the apps filter.
nsbeta1- per Nav triage team
Keywords: nsbeta1 → nsbeta1-
Comment on attachment 69436 [details] [diff] [review] patch r=law Definitely an improvement.
Attachment #69436 - Flags: review+
Comment on attachment 69436 [details] [diff] [review] patch sr=blake
Attachment #69436 - Flags: superreview+
per conversation with law, we decided to also include *.com in the extension list for Windows.
Once the Windows and *nix versions land re-assign to sdagley for the Mac fun
shouldn't this be plussed since it blocks bug 128667, which has been plussed? thus renominating.
Keywords: nsbeta1- → nsbeta1
QA Contact: jrgm → sairuh
not going to make 0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.0
nsbeta1- per Nav triage team, ->1.2
Keywords: nsbeta1 → nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2
It looks like this patch needs to be updated to include Mac, now that Mac supports a filter list. Steve, do you think you could do that, or give me a pointer on how to do it?
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
rather, reopening and -> dagley for mac impl
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: bryner → sdagley
Status: REOPENED → NEW
Since I don't report into Internet Technologies anymore this bug needs a new owner -> saari
Assignee: sdagley → saari
->ccarlen (guessing ownership)
Assignee: saari → ccarlen
Taking for 1.4b. If we need this sooner, let me know.
Status: NEW → ASSIGNED
Target Milestone: mozilla1.3alpha → mozilla1.4beta
15 years ago
This is not just a matter of filtering... in "Pick an application" mode we need to behave very differently in a number of ways. See bug 82860 and bug 185831 for some examples... (and on Windows, eg, we should put up the platform app picker).
Could the Mac version also set the default location to be '/Applications' now that we're only running on OSX?
You need to log in before you can comment on or make changes to this bug.