973248 - [UX] Australis - Add CSS transitions to Panel menu footer

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Right now, the Panel Menu footer buttons feel heavy without transitions. Also, the subview footer has those, only the main view (with Customize, help and exit)  is affected.

I have also noticed another issue regarding the main view footer, it's not as tall as the subview footers.

Two solutions for these issues :
- Use the panel-subview-footer class
- Fix this bug "manually" without the class

Comment 1

[Tim Nguyen :ntim]

The footer size bug is here : https://bugzilla.mozilla.org/show_bug.cgi?id=963002

Comment 2

[Tim Nguyen :ntim]

Also, the active state shadow of the footers (subviews and main view) should be thicker.

Comment 3

[:Gijs (he/him)]

I really don't think this is important right now. Probably not even P3-, more like P4, P5. Why did you mark it as P3?

Comment 4

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #3)
> I really don't think this is important right now. Probably not even P3-,
> more like P4, P5. Why did you mark it as P3?

Well P3 because it's a consistency problem.

Comment 5

[Justin Dolske [:Dolske]]

That's not how priorities are defined. Please let us manage the priorities; flag them as [Australis:P?] if you feel compelled to mark prioritized bugs.

Which platforms is this for? These buttons have obvious mouseover transitions on OS X, and also on Windows as best I can tell over RDP.

Comment 6

[Tim Nguyen :ntim]

(In reply to Justin Dolske [:Dolske] from comment #5)
> That's not how priorities are defined. Please let us manage the priorities;
> flag them as [Australis:P?] if you feel compelled to mark prioritized bugs.
> 
> Which platforms is this for? These buttons have obvious mouseover
> transitions on OS X, and also on Windows as best I can tell over RDP.

I'm using Windows.
---
Looking at [0], I see the that the transition is badly coded. This is parsed as transition: background-color 0s;
So basically, there is no actual transition here.

It would be nice if these rules actually match the ones used by .panel-subview-footer.subview-button in [1] and [2]

[0] : http://lxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#337
[1] : http://lxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#495
[2] : http://lxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#575

Comment 7

[Justin Dolske [:Dolske]]

Ah, yes, now that I'm on a live Windows box I see there's clearly no transition (easiest to see by rapidly flickering over the quit button, which goes bright-red upon mouseover). And, uhh, now that I do that on OS X it's also clearly without a transition.

P5 is still appropriate.

Comment 8

[Tim Nguyen :ntim]

I'm addressing this in bug 963002 .

Comment 9

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] from comment #8)
> I'm addressing this in bug 963002 .

No longer addressing this in bug 963002, so UX can be discussed here.

Comment 10

[Tim Nguyen :ntim]

None of the buttons have CSS transitions anymore. Everything is consistent ! 🎉