973294 - Firefox counts the number of times that users pick "Show Original"

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Marco Mucci [:MarcoM]]

1.  Goal
* As a product owner I want to know how many times users chose to use our translation feature so that we can get a sense of the size of the user problem we are addressing by offering this feature

2.  Acceptance Criteria
* I can view a report that tells me…
** How many times users selected “Translate” on the Infobar
** How many times users selected “No, Thanks” on the Infobar
** How many times users changed language pairs after the initial translation to get a different translation
** How many times they selected “Show Original” 
* This report will be updated weekly

Comment 1

[Benjamin Smedberg]

Related or almost a duplicate of bug 973293; I asked some questions there.

Comment 2

[Benjamin Smedberg]

What does "changed language pairs" mean in this context? Does this mean that we also need to record the language pair when the user chooses translate in the first bullet point?

Comment 3

[Chad Weiner [:chadw]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> What does "changed language pairs" mean in this context? Does this mean that
> we also need to record the language pair when the user chooses translate in
> the first bullet point?

When the user lands on a page written in a language other than their default language, Firefox will offer to translate it from the language it believes the page to be written in to the user's default language.  We care about assessing the following how well Firefox is detecting the language that the page is written in.  

There are at least two indicators of quality, we think.
1. How many times the user changed the language pair before selecting "Translate" for the first time 
2. How frequently users must try a different pair other than the one initially suggested by Firefox after they have accepted Firefox's initial offer of translation without making changes to the suggested pair.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

This isn't prioritized at the moment but bug 978158 will introduce a "recordTranslation()" method which can be used to record this data. Should be very simple to fix.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Marco Mucci [:MarcoM] from comment #0)
> ** How many times users selected “Translate” on the Infobar

Covered by bug 973292.

> ** How many times users selected “No, Thanks” on the Infobar

Bug 977774.

> ** How many times users changed language pairs after the initial translation
> to get a different translation

Bug 977770.

> ** How many times they selected “Show Original”

Seems like this bug should then only be about that last one? We would need another method on the TranslationProvider for that one.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Tim Taubert [:ttaubert] from comment #6)
> > ** How many times they selected “Show Original”
> 
> Seems like this bug should then only be about that last one? We would need
> another method on the TranslationProvider for that one.

Did I get that right, Chad?

Comment 8

[Chad Weiner [:chadw]]

Hey Tim, 

If the other requirements are met by the other bugs you mentioned, then yes, we need to address:  

"how many times they selected "Show Original".

Thanks!

Comment 9

[Asaf Romano (gone)]

Attachment: patch

One problem: in the browser test, we need to somwhow wait for the telemetry task to finish.

Comment 10

[Asaf Romano (gone)]

Attachment: patch

Just a typo after all.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 8444283 [details] [diff] [review]
patch

Oh crap, I forgot I commented out that line :(

Comment 12

[Asaf Romano (gone)]

Attachment: patch

Comment 13

[Asaf Romano (gone)]

Attachment: patch.diff

Comment 14

[Asaf Romano (gone)]

Attachment: patch.diff

Comment 15

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8444314 [details] [diff] [review]
patch.diff

Review of attachment 8444314 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/docs/dataformat.rst
@@ +1566,1 @@
>  

A little down below there's the example section where showOriginalContent should also be added.

Comment 16

[Asaf Romano (gone)]

https://hg.mozilla.org/integration/fx-team/rev/895eeb7bddb8

Comment 17

[Carsten Book [:Tomcat]]

sorry had to backout this change in https://tbpl.mozilla.org/?tree=Fx-Team&onlyunstarred=1&rev=0b7d0cbaa2bd since one of this 2 patches seems to have caused test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=42331284&tree=Fx-Team

Comment 18

[Asaf Romano (gone)]

Relanded along with the patch for bug 1029363 that should fix that failure.

https://hg.mozilla.org/integration/fx-team/rev/205fc57a7d32

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/205fc57a7d32

Comment 20

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8444314 [details] [diff] [review]
patch.diff

[Approval Request Comment]
Bug caused by (feature/regressing bug #): This bug is part of the automatic translation feature, which we want to A/B with a subset of Aurora 32 users.
User impact if declined: Data about users clicking the "Show original" button won't be collected
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): minimal
String or IDL/UUID changes made by this patch: none

Comment 21

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d115bce92169