973306 - jsapi-tests/testJitRValueAlloc.cpp:22: error: undefined reference to 'js::jit::RValueAllocation::write(js::jit::CompactBufferWriter&) const' (--disable-ion)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan Beich]

$ ./configure --disable-ion --with-system-icu
$ gmake
...
_virtualenv/bin/python config/expandlibs_exec.py --depend .deps/jsapi-tests.pp --target jsapi-tests --uselist --  c++ -o jsapi-tests -Qunused-arguments   -I/usr/local/include -Qunused-arguments -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Werror=conversion-null -Wsign-compare -Wno-invalid-offsetof -Wno-c++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-mismatched-tags -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pipe  -DNDEBUG -DTRIMMED -g -O -fomit-frame-pointer Unified_cpp_js_src_jsapi-tests0.o Unified_cpp_js_src_jsapi-tests1.o Unified_cpp_js_src_jsapi-tests2.o Unified_cpp_js_src_jsapi-tests3.o   -pthread  -Wl,-z,noexecstack -Wl,-z,text -B build/unix/gold   -Wl,-rpath-link,../../../dist/bin -Wl,-rpath-link,/usr/local/lib   -L../../../dist/bin -L../../../dist/lib ../libjs_static.a  -lz  -lm  -licui18n -L/usr/local/lib -licuuc -licudata
Executing: c++ -o jsapi-tests -Qunused-arguments -I/usr/local/include -Qunused-arguments -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Werror=conversion-null -Wsign-compare -Wno-invalid-offsetof -Wno-c++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-mismatched-tags -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pipe -DNDEBUG -DTRIMMED -g -O -fomit-frame-pointer js/src/jsapi-tests/tmpJWbQt5.list -pthread -Wl,-z,noexecstack -Wl,-z,text -B ../../../build/unix/gold -Wl,-rpath-link,../../../dist/bin -Wl,-rpath-link,/usr/local/lib -L../../../dist/bin -L../../../dist/lib ../libjs_static.a -lz -lm -licui18n -L/usr/local/lib -licuuc -licudata
js/src/jsapi-tests/tmpJWbQt5.list:
    INPUT("Unified_cpp_js_src_jsapi-tests0.o")
    INPUT("Unified_cpp_js_src_jsapi-tests1.o")
    INPUT("Unified_cpp_js_src_jsapi-tests2.o")
    INPUT("Unified_cpp_js_src_jsapi-tests3.o")

jsapi-tests/testJitRValueAlloc.cpp:22: error: undefined reference to 'js::jit::RValueAllocation::write(js::jit::CompactBufferWriter&) const'
jsapi-tests/testJitRValueAlloc.cpp:25: error: undefined reference to 'js::jit::RValueAllocation::read(js::jit::CompactBufferReader&)'
jsapi-tests/testJitRValueAlloc.cpp:22: error: undefined reference to 'js::jit::RValueAllocation::write(js::jit::CompactBufferWriter&) const'
jsapi-tests/testJitRValueAlloc.cpp:25: error: undefined reference to 'js::jit::RValueAllocation::read(js::jit::CompactBufferReader&)'
jsapi-tests/testJitRValueAlloc.cpp:22: error: undefined reference to 'js::jit::RValueAllocation::write(js::jit::CompactBufferWriter&) const'
jsapi-tests/testJitRValueAlloc.cpp:25: error: undefined reference to 'js::jit::RValueAllocation::read(js::jit::CompactBufferReader&)'
jsapi-tests/testJitRValueAlloc.cpp:22: error: undefined reference to 'js::jit::RValueAllocation::write(js::jit::CompactBufferWriter&) const'
jsapi-tests/testJitRValueAlloc.cpp:25: error: undefined reference to 'js::jit::RValueAllocation::read(js::jit::CompactBufferReader&)'
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [jsapi-tests] Error 1

Comment 1

[Jan Beich]

Attachment: disable file

RValueAllocation::write is defined in js/src/jit/Snapshots.cpp which is only built for ENABLE_ION case.

Comment 2

[Jan Beich]

powerpc64 fails a bit earlier
http://mozillaproject.osuosl.org:8010/builders/runtests/builds/979/steps/shell/logs/stdio

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8376791 [details] [diff] [review]
disable file

Review of attachment 8376791 [details] [diff] [review]:
-----------------------------------------------------------------

I would have done it within the test case but as we do the same thing in js/src/moz.build, this sounds like a better approach.
Thanks finding and fixing it :)

Comment 4

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a69d9510a54

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0a69d9510a54