Closed
Bug 973323
Opened 10 years ago
Closed 10 years ago
DispatchCompositionEventRunnable is spelled wrong
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: manishearth, Assigned: kunalarora.135, Mentored)
Details
(Whiteboard: [good first bug][lang=c++])
Attachments
(1 file, 2 obsolete files)
3.35 KB,
patch
|
smaug
:
review+
manishearth
:
feedback+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/search?string=compsotion&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central That should be spelled DispatchCompositionEventRunnable, not DispatchCompsotionEventRunnable.
Reporter | ||
Comment 1•10 years ago
|
||
Marking as good first bug. Any mentors?
Whiteboard: [good first bug][lang=c++]
Reporter | ||
Comment 2•10 years ago
|
||
Marking self as mentor as per suggestion in IRC. I'm not great with Mozilla C++, but I'm pretty sure I can help with this one, do try pushes, and help find reviewers. If you're interested in squashing this bug, please leave a comment! :)
Whiteboard: [good first bug][lang=c++] → [good first bug][lang=c++][mentor=manishearth]
Assignee | ||
Comment 3•10 years ago
|
||
hey, can i work on this one. looks simple enough and a good opportunity to get to know the code.
Reporter | ||
Comment 4•10 years ago
|
||
Here ya go, Kunal. Have you gone through https://developer.mozilla.org/en-US/docs/Introduction yet? It will tell you how to fetch the code and create a patch. If you need help on this, you can ask questions in the comments here or on the #introduction channel on irc.mozilla.org.
Assignee: nobody → kunalarora.135
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8376955 -
Flags: review?(manishearth)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8376955 [details] [diff] [review] spelling changes in TextComposition.cpp and TextComposition.h Review of attachment 8376955 [details] [diff] [review]: ----------------------------------------------------------------- By the way, the reviewer you want is :smaug, not me :) I can grant feedback on the patch. ::: dom/events/TextComposition.cpp @@ +122,5 @@ > > void > TextComposition::SynthesizeCommit(bool aDiscard) > { > +<<<<<<< local You seem to have some merge conflict cruft left over here, and below. Did you move the patch around? It seems like you tried a git merge or hg merge which wasn't successful, leading to these things (>>>>, <<<<<,=====) being left over. Were you using mq (qnew, qrefresh) to make this patch? If no, you may want to try it out, there's more information on that here: https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch @@ +141,4 @@ > } > +<<<<<<< local > + composition.DispatchCompositionEventRunnable(NS_COMPOSITION_END, data); > +======= More merging cruft
Attachment #8376955 -
Flags: review?(manishearth) → feedback-
Assignee | ||
Comment 7•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Attachment #8376955 -
Attachment is obsolete: true
Reporter | ||
Comment 8•10 years ago
|
||
Comment on attachment 8377038 [details] [diff] [review] spelling changes in TextComposition.cpp and TextComposition.h-- part2 Review of attachment 8377038 [details] [diff] [review]: ----------------------------------------------------------------- Pushed to try. (https://tbpl.mozilla.org/?tree=Try&rev=21dd372f13f0) I'm not too sure about the commit headers on this one, the parent commit doesn't seem to be mentioned. That's OK, we can fix that in IRC.
Reporter | ||
Comment 9•10 years ago
|
||
Alright, the commit headers seem ok, as verified in irc :) We'll wait for the tests to run, and then ask smaug for review.
Reporter | ||
Comment 10•10 years ago
|
||
Comment on attachment 8377038 [details] [diff] [review] spelling changes in TextComposition.cpp and TextComposition.h-- part2 Review of attachment 8377038 [details] [diff] [review]: ----------------------------------------------------------------- The try results look good, asking smaug for review.
Attachment #8377038 -
Flags: review?(bugs)
Attachment #8377038 -
Flags: feedback+
Reporter | ||
Comment 11•10 years ago
|
||
(You may want to add "; r=smaug" to the commit message of the patch.)
Comment 12•10 years ago
|
||
Comment on attachment 8377038 [details] [diff] [review] spelling changes in TextComposition.cpp and TextComposition.h-- part2 >-TextComposition::DispatchCompsotionEventRunnable(uint32_t aEventMessage, >+TextComposition::DispatchCompositionEventRunnable(uint32_t aEventMessage, > const nsAString& aData) align the latter parameter to be below the first one (add one space) >- void DispatchCompsotionEventRunnable(uint32_t aEventMessage, >+ void DispatchCompositionEventRunnable(uint32_t aEventMessage, > const nsAString& aData); ditto
Attachment #8377038 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8377126 -
Flags: review?(bugs)
Attachment #8377126 -
Flags: feedback?(manishearth)
Reporter | ||
Comment 14•10 years ago
|
||
Comment on attachment 8377126 [details] [diff] [review] bug973323.diff Review of attachment 8377126 [details] [diff] [review]: ----------------------------------------------------------------- Look good :)
Attachment #8377126 -
Flags: feedback?(manishearth) → feedback+
Reporter | ||
Updated•10 years ago
|
Attachment #8377038 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8377126 -
Flags: review?(bugs) → review+
Reporter | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 15•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9db0ee6f95e1
Keywords: checkin-needed
Comment 16•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9db0ee6f95e1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Reporter | ||
Updated•9 years ago
|
Mentor: manishearth
Whiteboard: [good first bug][lang=c++][mentor=manishearth] → [good first bug][lang=c++]
You need to log in
before you can comment on or make changes to this bug.
Description
•