Closed Bug 973338 Opened 6 years ago Closed 6 years ago

sync.dtd: add a localization comment explaining concatenation for signedInUnverified before/after label

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox29 --- fixed
firefox30 --- fixed

People

(Reporter: flod, Assigned: markh)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/rev/5c74030c7c0e

<!ENTITY signedInUnverified.beforename.label "">
<!ENTITY signedInUnverified.aftername.label "is not verified.">

As a general rule, concatenation is a poor design choice, variable substitution is much clearer and let localizers freely move the variable.

> signedInUnverified.label "#1 is not verified"

Since we're string frozen on Aurora, we need at least a localization comment explaining how these two strings are used.
http://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/sync.xul#225

Example

<!-- LOCALIZATION NOTE (signedInUnverified.beforename.label,
signedInUnverified.aftername.label): these two string are used respectively
before and after the account email address. Localizers can use one of them, or
both, to better adapt this sentence to their language.

Also, how is padding managed? I would expect concatenated strings to have starting/trailing spaces.
    1.90 +                  &signedInLoginFailure.beforename.label;
    1.91 +                  <span id="fxaEmailAddress3"></span>
    1.92 +                  &signedInLoginFailure.aftername.label;

has whitespace in the XUL file. Which would be a bug, if it wasn't an email address, which is latin by all chances and thus should probably have whitespace as delimiter.
I've added the localization note.  Should we still have a bug on file to fix this in 30?
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Attachment #8378052 - Flags: review?(ttaubert)
Attachment #8378052 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/57db16718921
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Comment on attachment 8378052 [details] [diff] [review]
0001-Bug-973338-add-a-localization-note-for-.before-and-..patch

[Approval Request Comment]
Comment-only "localization note" to help localizers.
Attachment #8378052 - Flags: approval-mozilla-aurora?
Attachment #8378052 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: Firefox Sync: UI → Sync
Product: Mozilla Services → Firefox
Target Milestone: mozilla30 → ---
You need to log in before you can comment on or make changes to this bug.