Closed Bug 973404 Opened 10 years ago Closed 10 years ago

[Sora][Download][DSW] Download manager was not fully backed out on 1.3

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P2)

defect

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 unaffected)

RESOLVED FIXED
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- unaffected

People

(Reporter: sync-1, Assigned: gwagner)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

107.85 KB, application/x-rar-compressed
Details
Mozilla build ID: 20140208004002
 
 Created an attachment (id=635762)
 QXDM
 
 DEFECT DESCRIPTION:
 There is no  download prompt message when you download music and video secussfully,even if the phone do not support the file,
 phenomenon of Beetle lite FF and soul3.5 FF is not  the same, Beetle lite FF can not download them 
 REPRODUCING PROCEDURES:
 1.Insert one sd card 
 2.go to "http://music.baidu.com" or “http://imps.tcl-ta.com/cailiang/media/e5_sound.html”;
 3.Select one song to download.There isn't any prompt,even if the file you do not support such as midi file,you can see the phone still download it and not remind users.->KO1
 4.go to "http://imps.tcl-ta.com/cailiang/media/e5_video.html"
 5.select "wmv",you will find there is no any prompt ,but you have download it into SD card.-->KO2
 EXPECTED BEHAVIOUR:
 when you download something ,you should give a prompt to remind users.
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 telephone:13818313480
 Mail:chunmei.zhang.com
 Skpye: Chunmei.zhang5 
 Microsoft Lync:chunmei.zhang.com 
 REPRODUCING RATE:5/5
 
 For FT PR, Please list reference mobile's behavior:
Attached file QXDM
How is the file being downloaded here? Are you using the save video/audio option here?
Flags: needinfo?(sync-1)
(In reply to comment #1)
 > Comment from Mozilla:How is the file being downloaded here? Are you using the
 > save video/audio option here?
 > 
 
 you click the "NotMp3DownFile.mp3" and then long click the black page. The save option will popup.
(In reply to sync-1 from comment #3)
> (In reply to comment #1)
>  > Comment from Mozilla:How is the file being downloaded here? Are you using
> the
>  > save video/audio option here?
>  > 
>  
>  you click the "NotMp3DownFile.mp3" and then long click the black page. The
> save option will popup.

Okay - I reproduced this. Looks like we're downloading the file here, even though the download manager isn't implemented on 1.3 right now.

Looks like this implies that the download manager wasn't fully backed out here then, as downloading appears to be partially enabled, but without the UX.
blocking-b2g: --- → 1.3?
Component: Gaia::Browser → Gaia::System
Flags: needinfo?(sync-1)
Switching title here to the problem - we've got a half-baked feature enabled on 1.3.
Summary: [Sora][Download][DSW]There is no download prompt message when you download music and video secussfully,even if the phone do not support the file → [Sora][Download][DSW] Download manager was not fully backed out on 1.3
blocking-b2g: 1.3? → 1.3+
Whiteboard: [systemsfe]
This was the behavior before starting to develop download manager, file appears that is being downloaded, but do not know where, so I do not think it is because download manager was not fully backed out in 1.3, just a missing or not fully implemented feature at that point
(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #6)
> This was the behavior before starting to develop download manager, file
> appears that is being downloaded, but do not know where, so I do not think
> it is because download manager was not fully backed out in 1.3, just a
> missing or not fully implemented feature at that point

Maybe - need someone to dig into this to confirm. As the reporter cites & I've confirmed this, on 1.1 if you visited an unknown mime type, you would not have the file silently downloaded in the background. On 1.3, the file is silently downloaded to the sdcard in the downloads directory of the sdcard.
Maybe Adam or Francis can help bring some clarity here.  This 1.3+ doesn't have an owner and hasn't moved in a couple days. Can we get next steps identified here please? Thanks!
Flags: needinfo?(fdjabri)
Flags: needinfo?(arogers)
The functionality that's there right now is "save as" with no prompting, which is expected, from my understanding when in the context of the browser.
(In reply to Ghislain Aus Lacroix [:aus] from comment #9)
> The functionality that's there right now is "save as" with no prompting,
> which is expected, from my understanding when in the context of the browser.

No it is not. Silent downloading was never present on 1.1 & would be terrible idea to ship with in a release. That automatically opens up an obvious sec-high bug in the product, which we are not allowed to ship with.
Assignee: nobody → anygregor
What about on 1.2? I just don't understand how we think this is a feature that is half baked when none of the code in gaia for this exists in the 1.3 branch. It's fine to want to fix it for 1.3 I guess, but it's new request, imo.
We need to backout bug 936342
https://hg.mozilla.org/mozilla-central/rev/9e31c9c04ccf is the exact revision we're going to back-out.
Flags: needinfo?(fdjabri)
Flags: needinfo?(arogers)
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/734238034ded
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: