Closed Bug 973557 Opened 8 years ago Closed 7 years ago

[CostControl][FTU] Update button active while is updating information

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
tracking-b2g backlog

People

(Reporter: lolimartinezcr, Assigned: mai)

References

Details

(Whiteboard: burirun1.3-3, burirun1.4-1, burirun1.4-2)

Attachments

(2 files)

Attached image 2014-02-17-04-17-05.png
Tested (02/17/2014)
Gecko-0b35113
Gaia-999808c

Pre-requisitos:
Prepaid SIM card and with billing support 

Step:
Tap Usage aplication

Actual result:
While balance is updated, "Update button" should be disable. See attached (2014-02.-17.04-17.05.png) image 
 
Expected result:
While balance is updated, "Update" button is disable.
blocking-b2g: --- → 1.3?
Whiteboard: burirun1.3-3
Summary: [CostControl][FTU] → [CostControl][FTU] Update button active while is updating information
Minor bug, not a blocker.
blocking-b2g: 1.3? → backlog
ni to UX to confirm what is the right behaviour. The update blue spinner is moving when the app is waiting for a balance sms, so if this sms is lost and the button is disabled, the user can not try to update the balance again.
Flags: needinfo?(aymanmaat)
Whiteboard: burirun1.3-3 → burirun1.3-3, burirun1.4-1
Flags: needinfo?(aymanmaat) → needinfo?(hello)
Whiteboard: burirun1.3-3, burirun1.4-1 → burirun1.3-3, burirun1.4-1, burirun1.4-2
Assignee: nobody → mri
Flags: needinfo?(hello)
Attached file patch v1.0
This solution deactivates the update of the smsCount when the configuration is in prepaid mode, it's necessary to prevent a race condition when a balance/topup sms was sent. This race condition produces the override of the settings waitingForBalance and waitingForTopUp.
Attachment #8435289 - Flags: feedback?(salva)
Comment on attachment 8435289 [details] [review]
patch v1.0

Salva, do you mind reviewing the code?
Attachment #8435289 - Flags: feedback?(salva) → review?(salva)
Comment on attachment 8435289 [details] [review]
patch v1.0

With this, we are no more counting the SMS of balance for telephony but it makes sense since in this mode, telephony counters are not displayed. Ok. It looks good to me.
Attachment #8435289 - Flags: review?(salva) → review+
Master: 86c019531ed0c1cb209aa8e4228dd2ea6539c15d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Tested and *not* working
Hamachi 2.0
Gecko-eb71d7a
Gaia-457921c

Update button is active while is getting balance
(In reply to Loli from comment #7)
> Tested and *not* working
> Hamachi 2.0
> Gecko-eb71d7a
> Gaia-457921c
> 
> Update button is active while is getting balance

Please, could someboy see this bug?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Loli - Can you open a followup bug for this?
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(lolimartinezcr)
Resolution: --- → FIXED
(In reply to Jason Smith [:jsmith] from comment #9)
> Loli - Can you open a followup bug for this?

Bug created: https://bugzilla.mozilla.org/show_bug.cgi?id=1041498
Flags: needinfo?(lolimartinezcr)
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.