Closed Bug 973606 Opened 7 years ago Closed 7 years ago

Fix alarms testcase, thrown exception has changed

Categories

(Calendar :: Alarms, defect, P1)

Lightning 2.6
x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

The error code has changed from NS_ERROR_XPC_JS_THREW_JS_OBJECT to NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS in the Mozilla platform, we need to adapt our testcase.
Attached patch Fix - v1 β€” β€” Splinter Review
Attachment #8377188 - Flags: review?(matthew.mecca)
Priority: -- → P1
Comment on attachment 8377188 [details] [diff] [review]
Fix - v1

I'll take a review from anyone else too in case Matthew doesn't have time :)
Attachment #8377188 - Flags: review?(Mozilla)
Comment on attachment 8377188 [details] [diff] [review]
Fix - v1

Looks good, r=mmecca
Attachment #8377188 - Flags: review?(matthew.mecca)
Attachment #8377188 - Flags: review?(Mozilla)
Attachment #8377188 - Flags: review+
Pushed to comm-central changeset dcadfa869307
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
You need to log in before you can comment on or make changes to this bug.