Closed
Bug 973606
Opened 11 years ago
Closed 11 years ago
Fix alarms testcase, thrown exception has changed
Categories
(Calendar :: Alarms, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.2
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
|
975 bytes,
patch
|
mmecca
:
review+
|
Details | Diff | Splinter Review |
The error code has changed from NS_ERROR_XPC_JS_THREW_JS_OBJECT to NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS in the Mozilla platform, we need to adapt our testcase.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8377188 -
Flags: review?(matthew.mecca)
|
|
Assignee | |
Updated•11 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8377188 [details] [diff] [review]
Fix - v1
I'll take a review from anyone else too in case Matthew doesn't have time :)
Attachment #8377188 -
Flags: review?(Mozilla)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8377188 [details] [diff] [review]
Fix - v1
Looks good, r=mmecca
Attachment #8377188 -
Flags: review?(matthew.mecca)
Attachment #8377188 -
Flags: review?(Mozilla)
Attachment #8377188 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Pushed to comm-central changeset dcadfa869307
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
You need to log in
before you can comment on or make changes to this bug.
Description
•