973627 - [ln10][es][Cost Control] String truncated in Spanish in data usage alert screen

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[isabelrios]

Attachment: String does not shown completely

Vendor build: 20140217

STR
With the device in Spanish, launch Usage app
Go through the First time experience
Look at the Data Usage alert

EXPECTED
Everything is translated correctly and fits the dedicated space

ACTUAL
The string indicating to activated the alert, set data alert, is correctly translated into Spanish, but the last letter 's' is behind the toggle. 
Please see screenshot attached.

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Inma, Ricardo, should we shorten or Salva, can we have less left margin?

Comment 2

[RickieES aka Ricardo Palomares]

I'd try first reducing the left margin.

If that's not possible, we could use "Alerta de uso de datos".

Comment 3

[Inma Barrios]

(In reply to Ricardo Palomares from comment #2)
> I'd try first reducing the left margin.
> 
> If that's not possible, we could use "Alerta de uso de datos".

+1.

Comment 4

[Salvador de la Puente González [:salva]]

I think this is caused by the change in building blocks for switches. Despite I agree the solution, I'm asking Arnau for what is better as the margins are part of the design.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

You should remove margins:
.settings li {
    margin-left: 1.5rem;
    margin-right: 1.5rem;
}

Please check if that impacts on settings view.
And ask for UI review to the visual design team after the patch :)

Comment 6

[Marina Rodríguez [:mai]]

Attachment: patch 1.0

Removed the margins, Arnau could you review the patch?
Regards

Comment 7

[Marina Rodríguez [:mai]]

Attachment: Screenshot without margins

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Marina, that screen is not well aligned, and the second line of text looks weird, do you have visuals for that one?
Pinging Eric for a visual reference or help to know how in the VD teams is working in usage app.

Comment 9

[Eric Pang [:epang] UX]

(In reply to Arnau March  [:arnau] from comment #8)
> Marina, that screen is not well aligned, and the second line of text looks
> weird, do you have visuals for that one?
> Pinging Eric for a visual reference or help to know how in the VD teams is
> working in usage app.

Hi Arnau, I beleive Vicky is working on the VD for the cost control app :).
Redirecting ni to Vicky.  Thanks!

Comment 10

[isabelrios]

Hi, now it appears 'Alerta sobre uso the datos' which fits the space. Please see screenshot attached
But as per comments #8 and #9 will keep the bug open till it is clarified how the screen should be presented.

Comment 11

[isabelrios]

Attachment: Text without overlapping the toggle

Comment 12

[Victoria Gerchinhoren [:vicky]]

(In reply to Eric Pang [:epang] from comment #9)
> (In reply to Arnau March  [:arnau] from comment #8)
> > Marina, that screen is not well aligned, and the second line of text looks
> > weird, do you have visuals for that one?
> > Pinging Eric for a visual reference or help to know how in the VD teams is
> > working in usage app.
> 
> Hi Arnau, I beleive Vicky is working on the VD for the cost control app :).
> Redirecting ni to Vicky.  Thanks!

Hi guys, no, I am not on top of Cost control visuals. NI to Stephany who should have more clarity on this.
Thanks!

Comment 13

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Stephany,
I was a bit concerned about the whole design for this screen, but we could try just to fix the margins for this bug, and create a new one to fix the text at the bottom, which looks a wit weird (text shadow...)

Comment 14

[Stephany Wilkes]

Vicki, that's our fault. We did have you on Cost Control per this page:
https://wiki.mozilla.org/Gaia/UXTeam

Flagging Jaime and Patryk to see who else can take this slot. 

Meanwhile, flagging Casey to advise on Arnau's suggestion in comment #13.

Comment 15

[Patryk Adamczyk [:patryk] UX]

I believe Omega has been assigned to this, so he's best to offer a resolution.

Comment 16

[Omega Feng [:Omega] [:馮於懋]]

Hi Patryk,
I don't think I'm assigned to this, and I'm a IxD btw. I can provide some UX feedback but I think we need a VxD to do a visual review for this app. Could you assign some VxD?

And here is a quick comment:
When tapping Back and Next, the page slides in/out. I think it should switch pages directly without any transition like what system FTU does, since there is already a progress indicator at top.

Comment 17

[Patryk Adamczyk [:patryk] UX]

I was hoping we currently had a standardize way of dealing with overflow, that's why I pinged you Omega. In a near future release we are slated to have a much more intelligent overflow solution with new controls.

The solution in Comment 11 solves the bug, so lets go with that.