973706 - Fix broken Casting:Stop functionality

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: fix-casting-stop v0.1

I had tried to remove CastingApps.closeExternal during the final review stages, but now discovered that we need the code to support the Stop/Disconnect code. This patch adds it back.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 8377279 [details] [diff] [review]
fix-casting-stop v0.1

Review of attachment 8377279 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/CastingApps.js
@@ +249,5 @@
>      }
>  
>      let status = aRemoteMedia.status;
>      if (status == "completed") {
> +      this.closeExternal();

Can you provide more context here? AFAICT, the only difference here is that you're using this.session.removeMedia instead of aRemoteMedia, Are they not the same?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8377279 [details] [diff] [review]
fix-casting-stop v0.1

The patch context doesn't include it, but "closeExternal()" is currently being called from here too:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/CastingApps.js#54

So we have two places in the code that want to "close the connection". Putting that code in a method is cleaner. The exiting code is calling a method that currently doesn't exist :)

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8377279 [details] [diff] [review]
fix-casting-stop v0.1

Review of attachment 8377279 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56d6251080cf

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56d6251080cf