973787 - [Gaia] SD card formatting: reword warning message

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Francesco Lodolo [:flod]]

Follow-up from bug 929860 comment 24

Current string: "It will erase all SD card data. Such as music or photos."

New string: "This will erase all data stored on your SD card, such as music and photos."

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16385

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Local test with Keon (screenshot)

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8377403 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16385

Please change to:

Format SD Card
--------------
This will earse all data stored on your SD card, such as music and photos.
[Cancel][Format]

Title: card -> Card; Remove "?"
Button: [OK] -> [Format] (use RED background color)

Thanks a lot!

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8377403 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16385

Updated pull request following suggestions.

Not really a developer here, so I hope that adding the class "danger" was the correct choice. I don't think I ever saw a dialog with both "danger" and "recommend" though (cyan and red buttons).

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Updated screenshot on Keon

Comment 6

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8378122 [details]
Updated screenshot on Keon

Hi, it still need two modifications:

(1) Title: Please use "Format SD Card" instead of "Format SD card".
(2) Button: "Cancel" should have WHITE background. (Sorry I just missed this one in the previous feedback.)

Thanks a lot!

Comment 7

[Francesco Lodolo [:flod]]

Aren't we using sentence case for titles? Or has that changed?
https://developer.mozilla.org/en-US/Apps/Design/Content

Comment 8

[Francesco Lodolo [:flod]]

Attachment: Updated screenshot without recommended button

I've updated the PR fixing the Cancel button, but I'd like an answer to the above comment before changing the title too.

Comment 9

[Omega Feng [:Omega] [:馮於懋]]

(In reply to Francesco Lodolo [:flod] from comment #7)
> Aren't we using sentence case for titles? Or has that changed?
> https://developer.mozilla.org/en-US/Apps/Design/Content

We'll use title case in the near future, and will have some way to change them altogether.
However, I've discussed with Harly who's in charge of Building Blocks, since we are using the new Building Blocks, so yeah, please keep sentence case for now.
Thanks for your carefulness.

Comment 10

[Omega Feng [:Omega] [:馮於懋]]

(In reply to Omega Feng [:Omega] from comment #9)
> (In reply to Francesco Lodolo [:flod] from comment #7)
> > Aren't we using sentence case for titles? Or has that changed?
> > https://developer.mozilla.org/en-US/Apps/Design/Content
> 
> We'll use title case in the near future, and will have some way to change
> them altogether.
> However, I've discussed with Harly who's in charge of Building Blocks, since
> we are using the new Building Blocks, so yeah, please keep sentence case for
> now.
> Thanks for your carefulness.

I mean, it's good to use "Format SD card" for now.

Comment 11

[Francesco Lodolo [:flod]]

Thanks, pull request should be good to review then. I see a Travis failure on linters, but I don't think it's a real failure.

Comment 12

[[e-mail], [e-mail]]

Comment on attachment 8377403 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16385

Hi Francesco, 

Thanks for your help on string corrected. The patch is good for me. The Travis build failed is stopped by itself. I think the patch is low risk. But it's better to let Travis run through the test case. Could you please "git push .." it again for trigger the test build? We're able to land it until got a green semaphore.:)

Comment 13

[Francesco Lodolo [:flod]]

I tried but still failing for timeout (this time on marionette_js).

Comment 14

[Francesco Lodolo [:flod]]

Finally passed
https://travis-ci.org/mozilla-b2g/gaia/builds/19270108

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Master: 2354098e1686bc147607f39e782ee1f66e40cfcd

Comment 16

[Francesco Lodolo [:flod]]

Verified on Keon master (1.4 2014-03-01 git commit f6f23511).